From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8QEaIQ5NrGei/CsAWB0awg (envelope-from ) for ; Wed, 12 Feb 2025 02:26:06 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=PHwHYz5W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 786561E105; Wed, 12 Feb 2025 02:26:06 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E26AB1E05C for ; Wed, 12 Feb 2025 02:26:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 491A6385840B for ; Wed, 12 Feb 2025 07:26:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 491A6385840B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=PHwHYz5W Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id A83BB3858C52; Wed, 12 Feb 2025 07:25:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A83BB3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A83BB3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739345120; cv=none; b=RKP81+l1OglwxdxRG2nMs4x8vjV1oZYfw6Cre70pv7ej7bfemBn1fWW8chnF0a0tZ2cpuXA5IV9SNl/9rZsHSq1529eswVWV30TrN6g8qBRTNZBIRZ5GQPfu4Mq77S1gDqsEcqilyKw8ETwUFGi2TJAqaQjr+Ve1b4vXkkUR0uY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739345120; c=relaxed/simple; bh=fc3SOTysd3YMbHZ+20EoNpOiGmg7+e9mLlyWSkcB0PA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=MrijnUugnzNCKWIn/a210xbF1KmdX3D+vTPdYmp7uZbsg/5TWZAsaehLdonXs5CJCH9aCOhdL17ArdpnJuTq04cspjT/sL0pJcS2FuNvCx7OwkLW7lrG0oe4enyG6Wl+Gesg4og6TP/INQr7qkyTkycN3s8idiiRHco0/ujyDkU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A83BB3858C52 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-21f7f03d856so65695195ad.1; Tue, 11 Feb 2025 23:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739345120; x=1739949920; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hSzoY/FrEWC4uYJy1fxTFlJnoM4Ug+Mh4fYEuPREidg=; b=PHwHYz5Wy9M7fIM+LUv35d8zvp4fua6ZKloLjtW6lfN9iXYbdTqLoS5z16hRlwIE6c Sw3fUTBKTmdTbb9QBZUnwwYospkrY3R+xRkTqR3nNvvxd4yJhqgnlQEGuhWvUNDFJVSl hgtIGPduoP1KFweKOUtf1Q179YqubHFJD5Z9+9rVLpf6ufMJM0xbK+KGhfLe4P7w1k6O tPTU9A6KEjppthfXdErEzAqdiyejJgVQYI/Oh/HRzQtXFjtFYWyAaWpI14Bj73z9u8f1 J0s1UFjeCoUBFrh9ZsG6jkClCwnvYMV2a3hgcFViWF7mKah7XgjXvAWaK6oj4jKZH3wV uPbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739345120; x=1739949920; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hSzoY/FrEWC4uYJy1fxTFlJnoM4Ug+Mh4fYEuPREidg=; b=kohlQCi8oOlw6zfHYCgVsD16ZdWMtGMDMfc4nxZRGi9HwDQGPrjymYK4nekibBbH0b WylgAkjhC+TXDzz4xIipu+UjzXlpepF6UbAIiTULDPX64BwB2XaIQ6vM/KSoXuYnPBJg qh0Dk1uz5RYh+42dwI0DVVy9ZyoYKEaE3lnBfRn051cYM+xpv9A8j5TdN+4p4PgDgD6f O1Ffre6g+Odje/UOT0yoNRIurZuphr/vupyX0sxioznyzAR/qBHQOL3h2X1D33QoE6uN fYhajdSGkzcsr5hY/2LQxfo9QTINr82jiFhRTp2up46SHoq5EWjYv7EGLM0drWT3FnTY wxLA== X-Forwarded-Encrypted: i=1; AJvYcCX+jWQBDO1XWVQNbHJxbk3/UlhAw66xa9UpV/xZ/qAMNURvruCoN4DrfBHUKhI/TAVL1Jvn+L481g==@sourceware.org, AJvYcCXjm9pTN3DIddDHPum8J0Yn968PKhS6YuxaCt2PF2ZPKEZFsWTOVt51jmKxZ75PRTx2gjJE8PTy9Ug2l1Q=@sourceware.org X-Gm-Message-State: AOJu0YwL11OROWhYxzgowcXabP5u+qpSR/3WI+gINZPp5v7rV4ryrRTN SXroAM8q2VuNXHwCCEPuSAAMc2aZ7beDRmMPKi5fFfn0kodpSnMM7K7cKg== X-Gm-Gg: ASbGncuJGJhhhRq7eIm1ReKihpch0OiEtfl/MPlQfjhJ4SCZxqITFPcj6kDUvu/wQ71 nbs8QUvu++Evm2oTuHj073bFpss9sdfkgMiQhtEzwSDKsLM1nWTHr0tLtq05cBM3XK3TVaviNfb w2xGri95ax3TFsOJmE33W7UZ+0lQ75unIWvNfE373TwCOZHHWWXL4ZfPwgaBKqSBibWO4PSTcz0 v6knVmMn+L66Ry1ynRE/rMw/GG1dVKBXCioOq69RIsMOodD04Kd00H97PJF4LnAC8CPLhna0eqY sFvas7y0dxWj3vnW+kQXn+xmRDZN X-Google-Smtp-Source: AGHT+IExNHDLYnIE7DHzlOv1WtCT6A49sS6q+kUyrOkw/guLDVnppfJWV/O4ZK0cqNKuosoH9Lv9wA== X-Received: by 2002:a05:6a00:b89:b0:730:9752:d02a with SMTP id d2e1a72fcca58-7322c36aa03mr2909630b3a.4.1739345119630; Tue, 11 Feb 2025 23:25:19 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:ab5c:4fd8:7871:9a57]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73219ea34acsm2670615b3a.62.2025.02.11.23.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 23:25:19 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 8AB0D114211E; Wed, 12 Feb 2025 17:55:16 +1030 (ACDT) Date: Wed, 12 Feb 2025 17:55:16 +1030 From: Alan Modra To: Charlie Jenkins Cc: jiawei , Nelson Chu , Jan Beulich , Andrew Burgess , gdb-patches , Binutils Subject: Re: [PATCH 1/2] RISC-V: Fix abort when displaying .dword Message-ID: References: <20250211-fix_gas_abort-v1-0-afd9730f9c51@rivosinc.com> <20250211-fix_gas_abort-v1-1-afd9730f9c51@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250211-fix_gas_abort-v1-1-afd9730f9c51@rivosinc.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, Feb 11, 2025 at 09:08:30PM -0800, Charlie Jenkins wrote: > In the normal case an instruction won't be split into 5, 6, or 7 byte > sections. However a .dword disassembled with -D can cause an instruction > to split across the 6 byte boundary. 6 byte instructions were not > supported so riscv_disassemble_data() would abort. I think it is worse than just needing to cope with 5, 6, or 7 bytes. riscv-dis.c:1444 sets dump_size from riscv_insn_length which looks like it can be up to 22 bytes. A carefully constructed testcase that gets this value from riscv_insn_length but then has only 20 bytes in the section will result in riscv_disassemble_data being called with bytes_per_chunk of 20. cat > xxx.s <