From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eNKFG/yQiGcKrRAAWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 23:54:20 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=RZQyXj3w; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6DABD1E100; Wed, 15 Jan 2025 23:54:20 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F25E1E08E for ; Wed, 15 Jan 2025 23:54:20 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95411385E036 for ; Thu, 16 Jan 2025 04:54:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95411385E036 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=RZQyXj3w Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id D39063851C33 for ; Thu, 16 Jan 2025 04:53:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D39063851C33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D39063851C33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737003226; cv=none; b=Rutwt/ckRuSEcbOEcf0t04q68rB73QtFdWGRCECEX8lXvgXlQThZDyJTpcQrLDk+TiZjfSeSuBynzt5j+7VisgDnwtB6C7PLeAMHMTve4uRldJ7rmBdtQA+Imj0VDxxO9U637sTGGf66NWX7cFgBhadik0xnmRYBNxMqF3GkUwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737003226; c=relaxed/simple; bh=VqUFppyKYPA5gLkiP32URI3lif7f0gtOg8xfwumlyKk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=psoWbJCmICDLfClFBl8CXy0pnWqKbWKogZuBxbY0d3vAgSM7TQqy2Uvc6htZWgvIbs10BwIN+xSpARh+WJ18NY7FcfNpHB79Cd2ZChe08SGdUJaR1VXmsNZfAPDYT5c6IWOA/ohbbpCx2rQiCzrnN2bI+tpvMBUuM+GNdgCxggw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D39063851C33 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-43675b1155bso4309815e9.2 for ; Wed, 15 Jan 2025 20:53:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1737003223; x=1737608023; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ngZsys+Wbi3w+RWgBEO+tN760gylV9No6qYFO9Z/6qs=; b=RZQyXj3wQzeKy2EwiLkbiyiElnJRZ8ZF0Ltou6KTx69hyV/mYCh2tm1/IaBL6AEW/w TcKZpTDetUnXVPLMx0rZE2lzW+E0b9FZ8gpY3LkHx9FjcBQX5pcTTkO/fTCK0Thlaapx LDnlS+rCJZ7oAPBQ6xB9TWvoKicOA3NMi0foD42GCsIguCcuaGHMN5rQMvRpRKb46Wh4 Xm4ELVWoWVgjbsytP8cTViKMhOrgM9Bu88l27ifbkfiUKijt76PvX8XvVgXv4W417RDJ 6/fXTPrWZnzoh/skF7PHj3Kc9cRPEsw+bbvCUcnPK7hbiKjJsh9wWjUkPJJkxNwF8nnH Nthw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737003223; x=1737608023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ngZsys+Wbi3w+RWgBEO+tN760gylV9No6qYFO9Z/6qs=; b=FHewTfXnLo+9Yk2H6ROOORrKCRQ2sP0qytB+h+2f1n9NZD4Kui74u8dhaShkkhy9o/ RWd/kMRsoJh63/doREEEirwv1VaXi7CSKOA5uCW7zJwVUTyqvN9NDNwGAL9aQXPHO8JB UF2tyiwY6EQj1cae8fRpRJEASa8aXRO6wuGHMnfwJAK+li7jWTQENCW9r+wmxpSjZRM3 KUa627Z38aSCsKINoMntmI5vzfJSdsGDDYHcvUmphbVenH3MUud2vn1APrkXlIzUIjaz QEuJSMBXpxPipRAOcnIcitAFMUyHAHoAb7yi/21Huc0WfKbrUBPpb0m4oGYwmJ3nGMUi IOMw== X-Forwarded-Encrypted: i=1; AJvYcCUUxmIUkcn7KV1VJaqpRjM7UAYiS7lINqKX5/6KzXeO30TOpE/Zq5i45bgi7t6s7aAUv1fFqVUYHUW9Kg==@sourceware.org X-Gm-Message-State: AOJu0YyOpVb1Rs2+HzsR/SdhZbAoOf4YuHhkKZplOV3XhFSXcFq4HQXw vvKsq/WfqRvUG06fmbyraUJqdrvAAlX+1t6fIC1UzEJD5P0KifkL75V5j/Vq X-Gm-Gg: ASbGncvDH42oBE0jd5N5eNONQQUC6p6djXmuam5DAdFi0t65utsH6W2CEaJydKAXk08 6KLDjv8Uksd5/OC7rwF9SF5diIQNx1oD+YrJglIyNhNqTtocFZVkai7adimkWV23s+nbeHsaEjB gWRajv9YjGCj/IT9U6n40l8IVyxIP9mp/mPWw+1WeAgXNZ2xprA8vBqD4SNRPIW7Frt8xJI4tdh 0RVjhlxSS0752wxOiudsQ8UlumjGfgxDdmQp7VmFi1YC5DxvT1hPdQBMYABUylf1d0= X-Google-Smtp-Source: AGHT+IFc3HlGOYspAJx1glagRCZjh5ri9WbD1BH+xfJaScvheKDDzfWTq41di3ovReGTeElr1hisxg== X-Received: by 2002:a5d:598b:0:b0:38a:5ce8:df6d with SMTP id ffacd0b85a97d-38a872fb0eemr26650054f8f.1.1737003223358; Wed, 15 Jan 2025 20:53:43 -0800 (PST) Received: from takamaka.gnat.com ([2a01:cb22:1d5:1100:5d90:8cf:5325:ac17]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c1664e8dsm53353005e9.1.2025.01.15.20.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 20:53:42 -0800 (PST) Received: by takamaka.gnat.com (Postfix, from userid 1000) id AB90E80D9F; Thu, 16 Jan 2025 08:53:40 +0400 (+04) Date: Thu, 16 Jan 2025 08:53:40 +0400 From: Joel Brobecker To: Sergio Durigan Junior Cc: Simon Marchi , GDB Patches , Simon Marchi , Joel Brobecker Subject: Re: [PATCH] gdbserver: Fix build on MIPS Message-ID: References: <20250116011055.4022193-1-sergiodj@sergiodj.net> <6cb5835d-3c50-4fd1-a9a7-39ac2c1d66d6@simark.ca> <87frlj766f.fsf@sergiodj.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87frlj766f.fsf@sergiodj.net> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Sergio, On Wed, Jan 15, 2025 at 11:07:20PM -0500, Sergio Durigan Junior wrote: > On Wednesday, January 15 2025, Simon Marchi wrote: > > > On 2025-01-15 20:10, Sergio Durigan Junior wrote: > >> Commit 3470a0e144df6c01f8479fa649f43aa907936e7e inadvertently broke > >> the build on MIPS because it's passing a non-existent "pid" argument > >> to "proc->for_each_thread". This commit fixes the problem by removing > >> the argument from the call. > >> > >> Signed-off-by: Sergio Durigan Junior > >> --- > >> gdbserver/linux-mips-low.cc | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/gdbserver/linux-mips-low.cc b/gdbserver/linux-mips-low.cc > >> index 98733709fa3..fafcdefbb06 100644 > >> --- a/gdbserver/linux-mips-low.cc > >> +++ b/gdbserver/linux-mips-low.cc > >> @@ -623,7 +623,7 @@ mips_target::low_remove_point (raw_bkpt_type type, CORE_ADDR addr, > >> &priv->watch_mirror); > >> > >> /* Only update the threads of this process. */ > >> - proc->for_each_thread (pid, update_watch_registers_callback); > >> + proc->for_each_thread (update_watch_registers_callback); > >> > >> return 0; > >> } > > > > Thanks for catching this. > > > > Approved-By: Simon Marchi > > Thanks; pushed. Branch gdb-16-branch also contains 3470a0e144df6c01f8479fa649f43aa907936e7e, so I'm wondering if it might be worth backporting this change to that branch as well? (just in time for teh 16.1 release, which is currently scheduled for this weekend!) -- Joel