From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wCdyLU85eGf6CgIAWB0awg (envelope-from ) for ; Fri, 03 Jan 2025 14:23:59 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=xLagsX71; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B3BE51E097; Fri, 3 Jan 2025 14:23:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 62AE11E05C for ; Fri, 3 Jan 2025 14:23:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9665C3858C56 for ; Fri, 3 Jan 2025 19:23:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9665C3858C56 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=xLagsX71 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 103E13858D28 for ; Fri, 3 Jan 2025 19:23:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 103E13858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 103E13858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::634 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735932198; cv=none; b=SaGUtNQ6qOZD/5KKQN5jFHHjg6cMSdpwwS1FlHCHAFQrlbAYi//aHEbLCZkOBlIJ/s8iBx/xAEjIqOXLUi93R7Ha48yfhZEe0Pj2ghC5fc2A1icEx9uRuNWYtf1xn+FIuTAqOEmlTo71jbIrAg9vXqzYRk1nZM0/ZzdrnA//nCU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735932198; c=relaxed/simple; bh=9pVMtGqM1bJ8Nq6OJ3+FD48FkWaoqjBQ1dn7hRJwQmU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=XkzysxX1/hf6v60QPptLEKq6amePWAV1xtaV+phPZwe8G6kCtsXpdJeWpScWsGtUtAlShY7p+fDqiLHMYywV9sK+XXCGvrc6Pqx4qyzPwMbA3QZFp0gn+/FhHN9gNgmltzqUY9QVBIwK5WaUG6MMFLjKL0u+UyqJIGWSe0O3Tng= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 103E13858D28 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2163b0c09afso173422505ad.0 for ; Fri, 03 Jan 2025 11:23:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1735932192; x=1736536992; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f0csFmM8LQmRZ1aB90Z32ek6dQfIAZXk0TGrL0DzKPM=; b=xLagsX71DMNuIcuB9iwywnDTdC6ckFI3RTy2zSddF3djhk8gPH1D0npCjE/Frukfr/ 3cLRgkccxypliHrnszWL8pRU+yEXvJHI5bjCBr3flD3f0q4gSQ1D3t7esGT55LbqQIpk uq8jIvIlLIkCZ5B9tlq1lTqEa6b39/dzT4O3cMFzj56yvugvKb+vmivRFqIo7S6Un8/8 cvsI/EZ593zNjstX29vwlpNMtGIMzlDoNMP/+ssvxdqgYW+ImVk/JYnYDWYM4NyyrBLz r6U697DT6/wNWA9Fy9gwXnWKAv/QA7LzK9e6WfeX4RhCnbpievJsCpwRAqiidHRIzzU3 +Eqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735932192; x=1736536992; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f0csFmM8LQmRZ1aB90Z32ek6dQfIAZXk0TGrL0DzKPM=; b=VIJNjAoUESobEIjZ0g98d9T72KN/sRQim7WlISmGr0AroozRJeBEypbMTxaInpfAfE zZBbKZQu/Rpbu/VZcR/RWeRPzpQD+oolBH7OUNIvmUeQns2x7YSJVpg4EHL3kEPc8jSN x9+l/5OcXnvuTYW38sEs5O/SRKpkc5dDXUc2TOSmOGb0eOb6Ejkl1PP1ZfXyxJhJJqql U8kspXfaDokDafSblVmK92vHt+VK+l7Td+J0dD/+635kd14Xqr+dmgg0bW/+GA92dEbl KLasYEx5kyuf08iJWHdggoyF2dXKw6Gi5IgN/+J6Z7t1REycPN60E9oiSRf0GONKGG4T I8iA== X-Forwarded-Encrypted: i=1; AJvYcCUKWRmrfmB0g1KXLfHlg+Q/coxmxt/hvrcw3Oq7rwsMWPKLLXMuw3vunxuSbfAnNDE7S8OuOXZj9hCPvg==@sourceware.org X-Gm-Message-State: AOJu0YzRUicjwFRANKPJUhefaaeRwcNXaX+nBRhMk6YHnnUwf9V91mFp 81P2DpQinLY7YyNLNdhaNyYjLSHhYahCCO1O3p4jOiqatYqy55yahK6R8e0RodE= X-Gm-Gg: ASbGncvxCL/SinIhc0MNbG3RJVN8tdjtxcuwPlv0cACxiCLJfrICJm7QHZqZeckSIKS P9HPAW38VKslhSk7Fifvw8YSq9qfpNIN6fDtInH/Kari9QrENKZVgKMQ+l+ToitywOeDO5AS7V3 bHgq+TUYhiaUaXnWyLvPC5pM+N3nPvAk6IC2TKVAA+LaS3dkbyxYFg4d8BVCjWjeRdqqg1ddR8X 7HyBQnyKiLAMxk/MeeH9alXajEFIpTB8VaSZ3G/snjU3sU20J4= X-Google-Smtp-Source: AGHT+IG9SPFceqyPKNCgZooRjg086sJ2w9z/XCUJfy00rei7rhY8MXkF2Q8TPZDC3tn/4ReY8E7bXQ== X-Received: by 2002:a17:902:e84b:b0:216:6f1a:1c77 with SMTP id d9443c01a7336-219e6f105d3mr679683525ad.43.1735932191826; Fri, 03 Jan 2025 11:23:11 -0800 (PST) Received: from ghost ([2600:1010:b0be:4797:42a0:3cad:ff5:6bb5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9d44a0sm247861875ad.165.2025.01.03.11.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 11:23:11 -0800 (PST) Date: Fri, 3 Jan 2025 11:23:09 -0800 From: Charlie Jenkins To: "Maciej W. Rozycki" Cc: Jan Beulich , Nelson Chu , jiawei , gdb-patches , Binutils , Andrew Burgess Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions Message-ID: References: <20241216-fix_objdump_partial_insn-v2-1-8de88a115dbc@rivosinc.com> <2b869ed1-5969-4ac8-890e-5c82f1877543@suse.com> <3bf293a6-63dd-4ee9-9b3c-368c48476513@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, Jan 03, 2025 at 06:22:34AM +0000, Maciej W. Rozycki wrote: > On Thu, 2 Jan 2025, Charlie Jenkins wrote: > > > > That or "display" instead of "disassembly", if you ask me. > > > > Sounds good, thank you for letting me know. Is there anything beyond > > this wording that is of concern in this patch? Unless there is anything > > else that needs to be changed, I can send a new version with the same > > diff (containing Nelson's comments) but change "disassembly" to > > "display" in the title and message. > > I think relevant test cases need to be added to the testsuite, I guess > under binutils/testsuite/binutils-all/riscv/ as this covers `objdump' > rather than any of the other tools. This is to guarantee things won't > regress again by accident. Yes that is a good point, I will add a test for this. - Charlie > > Maciej