From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ciWMGnWFDGLNIwAAWB0awg (envelope-from ) for ; Wed, 16 Feb 2022 00:02:45 -0500 Received: by simark.ca (Postfix, from userid 112) id 5B28B1F3C9; Wed, 16 Feb 2022 00:02:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E90901EA69 for ; Wed, 16 Feb 2022 00:02:44 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A69E3857C4E for ; Wed, 16 Feb 2022 05:02:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A69E3857C4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644987763; bh=ztbW6DG2rrlFuVrB1kFlF71mA1DiUspk8pqHYwo7QtY=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wkScIGSiokui7XXsa8d+eicnwduRNeTN8R5nem/1hzS3fx6h8kxe3aAlbKuPBt+lY XFZkxfaZjHBXgMJaiYiEiQfHb3TmKxP1D9LdXJYaxHGQG/3L0N3wEzweBT0EbWaNKe gGwCAv89x4RlAwSNdQx2MJMyU+O40XnWJnFjQqek= Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 8901B3858D3C for ; Wed, 16 Feb 2022 05:02:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8901B3858D3C Received: by smtp.gentoo.org (Postfix, from userid 559) id 2A579343404; Wed, 16 Feb 2022 05:02:25 +0000 (UTC) Date: Wed, 16 Feb 2022 00:02:23 -0500 To: Hans-Peter Nilsson Subject: Re: [PATCH 10/12] sim: Add sim_dump_memory for debugging Message-ID: Mail-Followup-To: Hans-Peter Nilsson , gdb-patches@sourceware.org References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230631.BA3A320439@pchp3.se.axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8AOVn0I1+ausK9Os" Content-Disposition: inline In-Reply-To: <20220214230631.BA3A320439@pchp3.se.axis.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --8AOVn0I1+ausK9Os Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 15 Feb 2022 00:06, Hans-Peter Nilsson via Gdb-patches wrote: > --- a/sim/common/sim-memopt.c > +++ b/sim/common/sim-memopt.c > > +/* Convenience function for use when debugging the simulator. */ can you clarify that it's meant for an attached debugger to call vs a manual call from within the sim itself ? i know your commit message said that, but the code comment would help too. i vaguely recall seeing another such hook point in the tree. i wonder if we should gather the prototypes in a single header and give them a dedicated symbol prefix to make them easier to discover. as it stands, i think you're prob the only one who will use this for quite some time as no one else will notice it :P. -mike --8AOVn0I1+ausK9Os Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIMhV8ACgkQQWM7n+g3 9YE7Bw/9FvCu/3ecv5gGg9P7WeI4EbX1wWuMrCvUJ52zb8p8QRXC1yb8h7SKsUzU tP48uDn0sZlmf8+CnP3fzJzuq3meftzKhU1zqqGQVEkWsUkeEmY3Fqnn9+bK+8Ml NcKL6XY+C5J4dn8ddPT3nSHVMYm5PQG8r5DF06KdsLVAx8VlwmoxdvaFc6layeq3 EaasNYQ15x7Nocj3qy19QuuOWiVivKu1gPakh7Bl1SkCljA8mM7d9FStu2pyxTsv 92Qy+jLbanWgfl6ewBa3cP7+5zzMvXuWcs7HxVR5aN60jLb8BWkE8Oi9VzTjcT3e 7KDKQoOFYJrO0G/kMq6diVdZSgELzLCxnp0CcXmD99OIe3L4bAwCrUGbAvb8hup1 YyHHuBw0WS9w393Ug540zqcijtFBaSA65EJoSnDvTis0vjcRFqPUh2NrXTwGaKdS Ms3VgaSE8CaJ//ypPbgBeTnQ/yBL7G9LYPnqiXsc3YEeh27fl43Fctm4qohSzxIp 4AUn5y/8VB9hJu71iUqR5Xu//anbGpIG/Ofv1FPWXlo8/Wl0d/5ZWRS+Qxvhji4I 5K3fDNB3WvPjPPg5NnkfG28GiztSAqX0dGEi0UcVovLvfNqKDTzwDr1KiDV5I+sY 5OJ98IHy+U/aDWUcCJTXX1q41zxBZOwR5Pwzcs8G6AszlvLLnCk= =ef9k -----END PGP SIGNATURE----- --8AOVn0I1+ausK9Os--