From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id S/KlBEGx3mHgegAAWB0awg (envelope-from ) for ; Wed, 12 Jan 2022 05:45:21 -0500 Received: by simark.ca (Postfix, from userid 112) id 02E1A1F34E; Wed, 12 Jan 2022 05:45:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 55D431F0BB for ; Wed, 12 Jan 2022 05:45:20 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4DCF393A42B for ; Wed, 12 Jan 2022 10:45:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4DCF393A42B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641984319; bh=av58tBhY3odjlTb1+nolaRZ/+GNokMOV0dRnqnQ0dC4=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=i1NoSbtZ0BJVgI7xlniHo90N2qO6kN5p55GFBYoCcBPXTo15qP7AnQbhHZely8fvc Zf3RvSeA75o3KcFahXz8BWDu4UJj+w0ij+Vli8T/Ormsxpq1FwBL5DOA4KvN738JHi ZCtrupxCFKdBYMauFs6iTtQTah7tqXGRzaj80qDY= Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 3879C3858416 for ; Wed, 12 Jan 2022 10:45:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3879C3858416 Received: by smtp.gentoo.org (Postfix, from userid 559) id B76EB342E02; Wed, 12 Jan 2022 10:45:00 +0000 (UTC) Date: Wed, 12 Jan 2022 05:44:58 -0500 To: Dragan Mladjenovic , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu , Faraz Shahbazker Subject: Re: [PATCH v3 1/4] sim: Allow toggling of quiet NaN-bit semantics Message-ID: Mail-Followup-To: Dragan Mladjenovic , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu , Faraz Shahbazker References: <20220111212406.32312-1-Dragan.Mladjenovic@syrmia.com> <20220111212406.32312-2-Dragan.Mladjenovic@syrmia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vTQ7TDy92zOavu51" Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --vTQ7TDy92zOavu51 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 12 Jan 2022 05:06, Mike Frysinger via Gdb-patches wrote: > On 11 Jan 2022 22:24, Dragan Mladjenovic wrote: > > --- a/sim/common/sim-fpu.h > > +++ b/sim/common/sim-fpu.h > > =20 > > +/* Toggle quiet NaN semantics. */ > > =20 > > +extern bool sim_fpu_quiet_nan_inverted; >=20 > please avoid global variables. this should be part of sim_fpu state inst= ead. hrm, that doesn't work as sim_fpu is an operand ... i was thinking it was t= he FPU state. all the sim-fpu APIs today have been assuming stateless FPU whi= ch doesn't really work after this (and the other changes you're posting). please add a new sim_fpu_state structure that this would be a member of. t= hat can be a global variable for now, but leave a TODO comment about moving it = into the SIM_CPU structure. -mike --vTQ7TDy92zOavu51 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHesSoACgkQQWM7n+g3 9YFeSg/+KQrrW5AgzHQ6oBVyHafOLNppUs6QGsMVJYx/Th9bRAjQccnj7xoJcPgk 7Buh4jyVc8syHwuT1n3XCZv/+8TneQOcVkup/v2T73SwtFSR9qJM7C0n7rDFHUi8 /VWiW5Ly24dKHuG8bfuAfppkkamNk8rHEroTkl/jjMJUiW0HhX2Shp9gSpPbtcdM Mdj4Krqdt3TLNl5Y54DaiYN8NXrMDwUn54BZEJV0ynzIlUtnsPLTNRtkpUgqK8sZ 0BAFXecIojqTwjvY8LhYKlEgdfAVnpo+8E5H6rlAtWMLXVUuwZlEecYBefCCcObo qUfY5zvn+sZkq94F24AgW7e9GNXoxQKkglgHI6KcaDw2VYMyoJRRvGCKtYGwjps/ cFvpmgLnbnoWVom5I/D2CR+j+QHwBdKCWTDYU9INgEoo8CrAxtsuLKGHg/PY6n+R 9+GjllUVwKZXC1RufkHNL7JTfVsLyW/MiT/eDlDwjfw9nVC05uKN9WFM8fqXM137 sja8cbjyejYEl7cN6PvuVlT9VTB5uBAjdZQJ1d4dKORmmUS+plyi+yIw1oFmQkyj oN9i84PUWFWvLPsEhGhHqKMlbTMCKWwV99pnxQvefMrc8RKCFmq6DRj/bAfWOJTK 447/IWqUuArModt7VqwYc38Qn37o7nREG45rzdM8POnX6sC8VYs= =qy8D -----END PGP SIGNATURE----- --vTQ7TDy92zOavu51--