Re: [PATCH v3 1/4] sim: Allow toggling of quiet NaN-bit semantics

Mike Frysinger via Gdb-patches
2022-01-12T10:06:29Z

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

On 11 Jan 2022 22:24, Dragan Mladjenovic wrote:
> --- a/sim/common/sim-fpu.h
> +++ b/sim/common/sim-fpu.h
>
> +/* Toggle quiet NaN semantics. */
>
> +extern bool sim_fpu_quiet_nan_inverted;

please avoid global variables. this should be part of sim_fpu state instead.

also, include stdbool.h in the header since you're adding that type.