Re: [PATCH v3 4/4] sim: mips: Add simulator support for mips32r6/mips64r6

Mike Frysinger via Gdb-patches
2022-01-12T10:57:57Z

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On 11 Jan 2022 22:24, Dragan Mladjenovic wrote:

i don't have substantial feedback on this since i'm not a MIPS expert

> +static sim_fpu_status
> +inner_fmac (int (*sim_fpu_op) (sim_fpu *, const sim_fpu *, const sim_fpu *),
> + uint64_t op1,
> + uint64_t op2,
> + uint64_t op3,
> + sim_fpu_round round,
> + sim_fpu_denorm denorm,
> + FP_formats fmt,
> + uint64_t *result)
> +{
> + sim_fpu wop1, wop2, ans;
> + sim_fpu_status status = 0;
> + sim_fpu_status op_status;
> + uint32_t t32 = 0;
> + uint64_t t64 = 0;
> +
> + switch (fmt)
> + {

bad indentation on switch body. some other funcs in this patch have the same
problem, so please go through it and double check.

> + default:
> + sim_io_eprintf (SD, "Bad switch\n");
> + abort ();

when you have access to SD, you can use sim_io_error to do the msg+abort.
sim_io_error (SD, "%s: unaccounted switch", __func__);

if you have a sim_cpu, you can use CPU_STATE (cpu).