From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4uOaCyWo3mHWdwAAWB0awg (envelope-from ) for ; Wed, 12 Jan 2022 05:06:29 -0500 Received: by simark.ca (Postfix, from userid 112) id 1C3641F34E; Wed, 12 Jan 2022 05:06:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 874D11F0BB for ; Wed, 12 Jan 2022 05:06:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 037BD393A41B for ; Wed, 12 Jan 2022 10:06:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 037BD393A41B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641981988; bh=jUREMBcjl+DFXCDXvrDpgj+7cy30VbumcmjowonQCbU=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BNDplKLJ41lGnWdXShqth5az1gH56anz1qFtSG3Z6xEPjO9CMMrG41hS9lmJb1mm4 cBwWnwks9UQ0SFV1BxyZfOjXM9Ij/uAYrl6zlXgwR6AqsGhr+EHBd4PikfoStU15ZL pylp3B6ulOSaCGoM9yLpwOq3rObwWw9UcXcwsadk= Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id D0FA53858416 for ; Wed, 12 Jan 2022 10:06:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D0FA53858416 Received: by smtp.gentoo.org (Postfix, from userid 559) id 44027342B41; Wed, 12 Jan 2022 10:06:05 +0000 (UTC) Date: Wed, 12 Jan 2022 05:06:03 -0500 To: Dragan Mladjenovic Subject: Re: [PATCH v3 1/4] sim: Allow toggling of quiet NaN-bit semantics Message-ID: Mail-Followup-To: Dragan Mladjenovic , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu , Faraz Shahbazker References: <20220111212406.32312-1-Dragan.Mladjenovic@syrmia.com> <20220111212406.32312-2-Dragan.Mladjenovic@syrmia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SQTSGLjNXJIWs6EM" Content-Disposition: inline In-Reply-To: <20220111212406.32312-2-Dragan.Mladjenovic@syrmia.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Chao-ying Fu , Faraz Shahbazker , gdb-patches@sourceware.org, "Maciej W . Rozycki" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --SQTSGLjNXJIWs6EM Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11 Jan 2022 22:24, Dragan Mladjenovic wrote: > --- a/sim/common/sim-fpu.h > +++ b/sim/common/sim-fpu.h > =20 > +/* Toggle quiet NaN semantics. */ > =20 > +extern bool sim_fpu_quiet_nan_inverted; please avoid global variables. this should be part of sim_fpu state instea= d. also, include stdbool.h in the header since you're adding that type. -mike --SQTSGLjNXJIWs6EM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHeqAsACgkQQWM7n+g3 9YEykw//dXUrQxyzKMkQFXkytji7yQKvmmZQXpk8o/n9WeXIGX7TbaCz+MfZQ2Mu JDYkqy90w27bvdCViNTKEpae7Y1aB4swnvGGIC+MK2i55X3MBHQ5Mk9TpSJf3QsI /x433DAifyaav/B6AXwYJXQ7Na3CaXZhLSrPaHzdbRGNGGuj1aRFUyPjVzmHQuu4 /ebzfOkVq1kCywuD0+gUjHTpFd9eeaOvwqonNscDLJpHT1MqrzKm7Bn6+3JeFVyQ RRqlSgPeS366qMk+FI7R4IXKVkCi8ciZwjh8IlenX7hqS2rMutZreaOJNZAjCOQB 9xpXiwEnFbIKcmx+ZJxJAy9DArUYec4rCLodR+coXORkwvB/yIAKWuLPL9ku46jq GVIjXO/AMW40qEN482Xyo6wRFxUTd6fekqKjKYdAXM0jUrFQHfY2gCpFCSa9Xll8 ANIVNMwAO0ujnkFhHyMDFYIMuYBpURwddAzwrnPGj5NyBghyM+DBZU+9aNWZPOxZ 8MEcSjGcL+F3jyyU60AhMyMJuf9YvcexZjAHjCuEfjZQ+DjprgsAq5CvXyXynTkT RTUVbKC6CF63ahOZUut0v6lFpt/ej7n4KhazPRJzxCxYu/uJ7Ma7QBVDxCT623wG pzpIoV75xYoPuXbJdaNJIBe9TIcXPaLufj/ltDbLkl7NH9P//4c= =BnsF -----END PGP SIGNATURE----- --SQTSGLjNXJIWs6EM--