From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G1yKEDW03mHgewAAWB0awg (envelope-from ) for ; Wed, 12 Jan 2022 05:57:57 -0500 Received: by simark.ca (Postfix, from userid 112) id 3B6661F34E; Wed, 12 Jan 2022 05:57:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CE4211EA69 for ; Wed, 12 Jan 2022 05:57:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FC3D385AC32 for ; Wed, 12 Jan 2022 10:57:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FC3D385AC32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641985076; bh=OW5jz5qDHOpWNMhyrfCosb8TywFevpRNnBFJkdI7YsI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DCsO8oGBHGti0Q7vgejHGxRMCZWf6WsD2AQ7mF60mSQhNTTPDvXJHoF8c8+fAje6+ nhAXInXyIqoOfhnvsFoVEYPyCNTPvv4YvHKEdCXDYOh4743cIARkbsi5KAP1EPWfR7 auQT7jFUMj3KlcId531/PrLga2EI0lCmCFMUkBeY= Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 877D43858001 for ; Wed, 12 Jan 2022 10:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 877D43858001 Received: by smtp.gentoo.org (Postfix, from userid 559) id F3F683430F1; Wed, 12 Jan 2022 10:57:36 +0000 (UTC) Date: Wed, 12 Jan 2022 05:57:34 -0500 To: Dragan Mladjenovic Subject: Re: [PATCH v3 4/4] sim: mips: Add simulator support for mips32r6/mips64r6 Message-ID: Mail-Followup-To: Dragan Mladjenovic , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu , Faraz Shahbazker References: <20220111212406.32312-1-Dragan.Mladjenovic@syrmia.com> <20220111212406.32312-5-Dragan.Mladjenovic@syrmia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hQMJRHMnpv7TzFw6" Content-Disposition: inline In-Reply-To: <20220111212406.32312-5-Dragan.Mladjenovic@syrmia.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Chao-ying Fu , Faraz Shahbazker , gdb-patches@sourceware.org, "Maciej W . Rozycki" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --hQMJRHMnpv7TzFw6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 11 Jan 2022 22:24, Dragan Mladjenovic wrote: i don't have substantial feedback on this since i'm not a MIPS expert > +static sim_fpu_status > +inner_fmac (int (*sim_fpu_op) (sim_fpu *, const sim_fpu *, const sim_fpu *), > + uint64_t op1, > + uint64_t op2, > + uint64_t op3, > + sim_fpu_round round, > + sim_fpu_denorm denorm, > + FP_formats fmt, > + uint64_t *result) > +{ > + sim_fpu wop1, wop2, ans; > + sim_fpu_status status = 0; > + sim_fpu_status op_status; > + uint32_t t32 = 0; > + uint64_t t64 = 0; > + > + switch (fmt) > + { bad indentation on switch body. some other funcs in this patch have the same problem, so please go through it and double check. > + default: > + sim_io_eprintf (SD, "Bad switch\n"); > + abort (); when you have access to SD, you can use sim_io_error to do the msg+abort. sim_io_error (SD, "%s: unaccounted switch", __func__); if you have a sim_cpu, you can use CPU_STATE (cpu). -mike --hQMJRHMnpv7TzFw6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHetB4ACgkQQWM7n+g3 9YEtUw/7BL66eumpnzSt93b4JziMBxxmDmCBWTn8eLFcM/fWnM3FkDl8VFGbkIoH 0EKqIU4BJ1DoRS3F3AqlH+bfbfnzRfGTOCHok8P+aSUWRfSeCckoET2SI6sSEyAB nMzpe4yMzFRzJkQIhTJw+SkZaTC9H3QwFV2Aa0b0IiWFNq7WwBcQxcOoxCYzuYff MkaXyWnl2/T8S93jzuQhfPrRVAry0VW41EfQng2IUcqSJgqq89G/xXtIktV3SKGO gPbB+sGX9JwZiu5d7NE5efc8qt9086G1eQrLO0dhWpToLAdUTkHfWqqPOOQbskyR UX63sBXHrB61Zp096xXZK1xPl0PxJD63fSvuKD+tqKG62MTImJ1gTKvf7k2c6UEa ZmcxRX7DhalEH69qozeIoh9I/3rl7r9swt2emkUlbabJHrR2uwG7TcsgFLaJGhy4 YV1PG7py8y1uHiMDF2DbrSJRvAeFiW4Ns0tHFzpyi6Jeg7Ym1+Xp4RLFtEcUmiLq XofC7BqrOIAbhpI6UEpwqfXPA0KqjhLsQiMCnmZLimzlzGdIcN4Ri8R+d0iGaD2f kC6ZFvb/EKCXbe+9MzZaDgKwWurYhjSatKmIoOZPw1uIaeGmBO394miYKOdjWmJ9 0GypqDyWPoRMlspDLHnsiZee13S6pHsEV4EsLS+lJP8y5ejbA0M= =Seeq -----END PGP SIGNATURE----- --hQMJRHMnpv7TzFw6--