From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cK5lJpth3mHqZwAAWB0awg (envelope-from ) for ; Wed, 12 Jan 2022 00:05:31 -0500 Received: by simark.ca (Postfix, from userid 112) id 9AD351F34E; Wed, 12 Jan 2022 00:05:31 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 859B71E940 for ; Wed, 12 Jan 2022 00:05:27 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D4AFE38B3429 for ; Wed, 12 Jan 2022 05:05:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4AFE38B3429 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641963926; bh=DLCojJpe0rAd6rEtCIG28a4Rz4yAIrhLrSv/lXtBkZA=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DFsqKVYCptQXdLjbLcgQh2zlPgBTNj88jma8raGMba3HNobvcCzf+FzzXmtH1AeBq YKLxiSzvWKoSqqtr5kEuDUWqjqmesIM4Mv9yuvBONwRk9g1ma8df/7XrHHdiyMaIWN tKWhaDkhG++Mv/a5UQSYja9IeAO2hTzEV70SCkGc= Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 1B6D83858416 for ; Wed, 12 Jan 2022 05:05:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1B6D83858416 Received: by mail-wr1-x42f.google.com with SMTP id q8so1943752wra.12 for ; Tue, 11 Jan 2022 21:05:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DLCojJpe0rAd6rEtCIG28a4Rz4yAIrhLrSv/lXtBkZA=; b=YV/mElo7qG9Z8N4jF493Bzn2sET2NaH6IhGh2TV8eXSetSEBD36UQvHs17gOu7KZbN V8EWqwEFdfLhzmjc0sM0+UWBmNeVNqRHFjsrgVPkMUBketkYtleFbs+/4BA8cD9kQjsc AJUZLy4Zwa4JXYLYEapfTWwniJ3eRXG644CjaGhea01EjiBcxuC9ZeIll1Z933c3VQOG +CHrqFr5GST/yuaXDSwLo3lASXiJf2O7dLEeCVAmZO+9PIGZh08XWiec1E19LpW/aVos 2sHH2GjuQmeMAkzr7Uyuq2IzWyPdZ74KcIRsu/4Le2FP6s5PcoSUb9NJLemK9T2Wt1Zs ofVA== X-Gm-Message-State: AOAM531hXJ49x75pom28FEYiIIRCs9kiSAnZE30IziOWpSMqqmjWVdzi sEO2yx4fXZvqiU/Gjxq9NQD2 X-Google-Smtp-Source: ABdhPJySHvR25UXpqU5sJDdzl8E+CUt8KtrmDKCady1O9Y55TKTXGYan/VEbAf4OYeLy5uVUy24NTg== X-Received: by 2002:adf:eb12:: with SMTP id s18mr6350009wrn.717.1641963907240; Tue, 11 Jan 2022 21:05:07 -0800 (PST) Received: from takamaka.home ([2a01:cb22:1d5:1100:9f61:c476:272f:db95]) by smtp.gmail.com with ESMTPSA id h13sm7879824wrx.8.2022.01.11.21.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 21:05:06 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id 61FC6A4A59; Wed, 12 Jan 2022 09:05:04 +0400 (+04) Date: Wed, 12 Jan 2022 09:05:04 +0400 To: "Aktemur, Tankut Baris" Subject: Re: [PATCH] sim: filter out SIGSTKSZ [PR sim/28302] Message-ID: References: <20211003160916.13080-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Joel Brobecker via Gdb-patches Reply-To: Joel Brobecker Cc: "gdb-patches@sourceware.org" , Joel Brobecker Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > > We map target signals to host signals so we can propagate signals > > between the host & simulated worlds. That means we need to know > > the symbolic names & values of all signals that might be sent. > > > > The tools that generate that list use signal.h and include all > > symbols that start with "SIG" so as to automatically include any > > new symbols that the C library might add. Unfortunately, this > > also picks up "SIGSTKSZ" which is not actually a signal itself, > > but a signal related setting -- it's the size of the stack when > > a signal is handled. > > > > By itself this doesn't super matter as we will never see a signal > > with that same value (since the range of valid signals tend to be > > way less than 1024, and the size of the default signal stack will > > never be that small). But with recent glibc changes that make this > > into a dynamic value instead of a compile-time constant, some users > > see build failures when building the sim. > > > > As suggested by Adam Sampson, update our scripts to ignore this > > symbol to simplify everything and avoid the build failure. > > > > Bug: https://sourceware.org/PR28302 > > This patch fixes a build problem that may be seen with GDB 11. Should > it be cherry-picked to gdb-11-branch to be included for the upcoming > 11.2 release? Thanks for highlighting this patch. It does seem interesting to have this patch in the 11.2 release, so go right ahead and backport. The patch already has a PR number, so this is good. I've changed the PR to add the target mileston set to 11.2 as required by our procedures, and re-opened the PR for now. Thanks, -- Joel