Re: [PATCH] sim: filter out SIGSTKSZ [PR sim/28302]

[Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>]

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

On 11 Jan 2022 15:14, Aktemur, Tankut Baris wrote:
> On Sunday, October 3, 2021 6:09 PM, Mike Frysinger wrote:
> > We map target signals to host signals so we can propagate signals
> > between the host & simulated worlds.  That means we need to know
> > the symbolic names & values of all signals that might be sent.
> > 
> > The tools that generate that list use signal.h and include all
> > symbols that start with "SIG" so as to automatically include any
> > new symbols that the C library might add.  Unfortunately, this
> > also picks up "SIGSTKSZ" which is not actually a signal itself,
> > but a signal related setting -- it's the size of the stack when
> > a signal is handled.
> > 
> > By itself this doesn't super matter as we will never see a signal
> > with that same value (since the range of valid signals tend to be
> > way less than 1024, and the size of the default signal stack will
> > never be that small).  But with recent glibc changes that make this
> > into a dynamic value instead of a compile-time constant, some users
> > see build failures when building the sim.
> > 
> > As suggested by Adam Sampson, update our scripts to ignore this
> > symbol to simplify everything and avoid the build failure.
> > 
> > Bug: https://sourceware.org/PR28302
> 
> This patch fixes a build problem that may be seen with GDB 11.  Should
> it be cherry-picked to gdb-11-branch to be included for the upcoming
> 11.2 release?

i don't normally pay much attention to branches.  but i can cherry pick
it back if people want it & branch maintainer approves it.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]