From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id glp7IVJFq2EPOQAAWB0awg (envelope-from ) for ; Sat, 04 Dec 2021 05:39:14 -0500 Received: by simark.ca (Postfix, from userid 112) id 71FF61F0CE; Sat, 4 Dec 2021 05:39:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C6B201EDEE for ; Sat, 4 Dec 2021 05:39:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E885385842E for ; Sat, 4 Dec 2021 10:39:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E885385842E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1638614353; bh=exmffo6XO9RTFZQVhvrrdw5uUhfzM74riXlh+gcPtM0=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Ju7eZb1G41r5Bc8gyIqtoEmEBaz7lJE48fIbctdXeTzvzXnHwyQpUkOS6ylBWMRjV QL3ySP9Fs6fs6ReQdv1fewAhK7+AEAM4GMBdC9zYxrVwvNxvn/9UabSefQUPYvxRFf sZ7QRuf7FPFk7OYGvCQcpapQq9uqu9La6UeLKAZ0= Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 454793858D28 for ; Sat, 4 Dec 2021 10:38:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 454793858D28 Received: by mail-wm1-x32c.google.com with SMTP id r9-20020a7bc089000000b00332f4abf43fso5807514wmh.0 for ; Sat, 04 Dec 2021 02:38:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=exmffo6XO9RTFZQVhvrrdw5uUhfzM74riXlh+gcPtM0=; b=TnEJj6fvV0WYtAg0EvywXNqrvzkRk9xd043L5yB2yyjeFtHLPEBl7EdVcG95m+NUo3 ctW3BOWRXJvkQfvRzi/rYss4IOgC5HebCYEm4yQVWZ1yGrYZMlMtYPPphEyYrDeDlqvJ qFVirAQI/FVW3ZAYNltcKopwDyeBtD08Rvu9CUNVOOkWykGi02XudlDv42ucnWZ1y3pT CWjqOHcFArvpxxw8bas/D7/SjXoNBxfqIKD0pOeIdnREsGx3zHPGgEA9z7rNq8Yg7kFj 8p5isvukYprGuxIUrjhcs2dULsDBjvphT31ZOfYCCgsdtQx8HPp3CgYIyzViid40SufL MEig== X-Gm-Message-State: AOAM531HH8Njxmz/WzPFpZgNGrgq3lhW5iSFJlAEQIPRp0NvmezKbYF+ cgTGug+arloFGZTy6rmGDZCh54AhIgIa X-Google-Smtp-Source: ABdhPJwMGcm8i4W/rg6MLN9BlBNrny0VDQv7zKgKeKcwUKiYPIW6+rH/cKUtZ36zJnoMFe58PwZbVg== X-Received: by 2002:a05:600c:198f:: with SMTP id t15mr22736830wmq.94.1638614334380; Sat, 04 Dec 2021 02:38:54 -0800 (PST) Received: from takamaka.home (lfbn-reu-1-483-157.w92-130.abo.wanadoo.fr. [92.130.72.157]) by smtp.gmail.com with ESMTPSA id m14sm7448302wrp.28.2021.12.04.02.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Dec 2021 02:38:54 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id 83236A5A43; Sat, 4 Dec 2021 14:38:51 +0400 (+04) Date: Sat, 4 Dec 2021 14:38:51 +0400 To: Tom Tromey Subject: Re: [PATCH 2/3] Move file_and_directory to new file and C++-ize Message-ID: References: <20211130013304.4135367-1-tom@tromey.com> <20211130013304.4135367-3-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211130013304.4135367-3-tom@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Joel Brobecker via Gdb-patches Reply-To: Joel Brobecker Cc: Joel Brobecker , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Tom, In addition to the comments already made about the name of the class members, I was wondering why you were adding the following include in this patch, since I didn't see any use of the file_and_directory. > diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h > index fe34e3f95ae..0afcda1c3b0 100644 > --- a/gdb/dwarf2/read.h > +++ b/gdb/dwarf2/read.h > @@ -23,6 +23,7 @@ > #include > #include > #include "dwarf2/comp-unit-head.h" > +#include "dwarf2/file-and-dir.h" > #include "dwarf2/index-cache.h" > #include "dwarf2/section.h" > #include "filename-seen-cache.h" Looking at the next patch, I think perhaps this include should be moved over to patch #3? -- Joel