From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8QeSKTqHe2GDVQAAWB0awg (envelope-from ) for ; Fri, 29 Oct 2021 01:31:38 -0400 Received: by simark.ca (Postfix, from userid 112) id 9826A1F0BB; Fri, 29 Oct 2021 01:31:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 03B571E813 for ; Fri, 29 Oct 2021 01:31:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89D443857416 for ; Fri, 29 Oct 2021 05:31:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89D443857416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635485497; bh=fCQ63Id5BsCehcnsPMqByrQlkJAeAch0Sag/c7sR+KY=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oJWPAArHQ79uQQMfduFWYdSYpJWdbYP5KU5snHwkF7ZY7dSlc/N53h1Vj0ZoPAN23 k2PzfCo10cknsAd7kuvIgl3wRwlAp4D5ft/zmusyLfmk0fVSf9/KLmRojF7FX11319 2/1KAFTJNwg0Cysd+yawp2EqpiYsHOl9/fSR+izc= Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 001FA3858C39 for ; Fri, 29 Oct 2021 05:31:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 001FA3858C39 Received: by smtp.gentoo.org (Postfix, from userid 559) id BACFD342FEE; Fri, 29 Oct 2021 05:31:17 +0000 (UTC) Date: Fri, 29 Oct 2021 01:31:18 -0400 To: Orgad Shaneh Subject: Re: [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings Message-ID: Mail-Followup-To: Orgad Shaneh , gdb-patches@sourceware.org References: <20211027062717.3056451-1-orgads@gmail.com> <20211028075540.174496-1-orgads@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="513umgTn/crba3OB" Content-Disposition: inline In-Reply-To: <20211028075540.174496-1-orgads@gmail.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --513umgTn/crba3OB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 28 Oct 2021 07:55, Orgad Shaneh via Gdb-patches wrote: most of the patch looks fine enough > @@ -1587,7 +1586,7 @@ memory_read(int32 asi, uint32 addr, uint32 *data, i= nt32 sz, int32 *ws) > *ws =3D mem_ramr_ws; > return 0; > } else if ((addr >=3D MEC_START) && (addr < MEC_END)) { > - mexc =3D mec_read(addr, asi, data); > + mexc =3D mec_read(addr, asi, (uint32 *)data); data is a void pointer, so you shouldn't need this cast in C > @@ -1607,7 +1606,7 @@ memory_read(int32 asi, uint32 addr, uint32 *data, i= nt32 sz, int32 *ws) > } else if ((addr >=3D 0x10000000) &&=20 > (addr < (0x10000000 + (512 << (mec_iocr & 0x0f)))) && > (mec_iocr & 0x10)) { > - *data =3D erareg; > + *(uint32 *)data =3D erareg; probably would be better to use memcpy on it -mike --513umgTn/crba3OB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmF7hyYACgkQQWM7n+g3 9YHTfxAAxZ7q24mQY4CVU3Mu6yuFFvAAC/HWi3X4X7xU+0CJPwhLCaZHMns5B0TE STOVCNhxFxFpbyaL+qerOTVp+Z9Lf3kiQfPp9d3HLR0iUgL/PlYTeq2Xyn8TnCpD 8RQgZlXgTlMMFBvQtUh0qoAXsvRmV5VpCjD/SO4MM0LwZpIvRIHYedZCKpv4BPId 8PJuklVKQu0LWLo1YZ7pnSxvsKi/bdArjPDKkhWHeo4MR2wpXyDGad53ETgBDvcd 3HDxQv4bH39voLa6QqODMZdsjOVd3ZuZyJUZ0YkQY/nz1FMQkEH71PYbGz++GKa9 OjvikLso+K69nlgCXapIGRXdj1muUAVl3jxZd5tL1mQ6UyEsv1c8HAYOV6PjpBMx z8hP9HsTo49Sl/PrIpIOITmYSdRHfA3E7TA6Pu0FnhUGSRvo/5lcigeUAiqG+SCb +//odiO3aRuFvCmw0LkBlH3IkwhRDQHca/8twSCpbqIlwt/JnE6jZ4J6/lkx54j5 Kw5Re4LZbxUQR7XEMBcth412FG0ipqmpjwo1vGpXHU0xANcYmG9PqOtNbAsS10W1 d9Ipkvj96wWewKvthn2aofvL7pK9o+CW7/dvOwLWs6r4AV6cAz5kbuHEjqs8WpFW NV4k5i0CHU1UoR5wevo5Cw9HYnsFsaY0T+xvizZs9ZPrr+YX/5k= =0QiN -----END PGP SIGNATURE----- --513umgTn/crba3OB--