From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VYtbF2mHcGEVMwAAWB0awg (envelope-from ) for ; Wed, 20 Oct 2021 17:17:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 57A961F0BD; Wed, 20 Oct 2021 17:17:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B5DAC1EDDB for ; Wed, 20 Oct 2021 17:17:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6EF9D3858030 for ; Wed, 20 Oct 2021 21:17:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6EF9D3858030 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634764648; bh=ijuvhYL5JqGnt8gwx4OcpOXNPQx8CIEzH4dWbQJMmNI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lFT6LcUdHMfp/73HeuZo6X49lqna5TqkDF1yx2DDnbsiuYhz2LdbdUhBmgu8lDyIJ ThCCiKoFoVNebaCr8SH0zjC08CPHF0zg5fWeHOvb9sZ80oOkxU/XYuKgPxQrNfSsbp qjWfIwgUZkDSgeczkURo33RWiRDjIJb65esHD7XA= Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 8F2003858D39 for ; Wed, 20 Oct 2021 21:17:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F2003858D39 Received: by mail-pj1-x102d.google.com with SMTP id u6-20020a17090a3fc600b001a00250584aso1499780pjm.4 for ; Wed, 20 Oct 2021 14:17:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ijuvhYL5JqGnt8gwx4OcpOXNPQx8CIEzH4dWbQJMmNI=; b=ipQAMXGgPzQ+f5sgStxIB5Cx6vyFgmmp+Lljhe67tAr1w5WopiGideWZEaPV/C+RDS JN/W+/cUS/LC40+TVsAXWE5dJR1DuwoGMcfVi94WTcojY7JQGxnvBElfZeqbKTamIHvv b/1Lq5yqgGI7oxNMG2gijGR68MITejigEl91LF7WBV/mK58Loo3dNDSlBdV2Vs7HF1tS riieuysLAog/HnCPKru046LQWixLeT95TXoruR4ezXrZRSApB+IC+n+FN/nOEqqiexV6 ApqqHVYPU4ty7PDhUgFi5hf/+LkcXX3gSVGS7PKXhfQ47imNeQSYSJvOALjUDCwuJLZ9 0FEg== X-Gm-Message-State: AOAM530IgrQbCQIgLzq0WZK9GFF9j4WoqhPVVn5fUM7VYb+bw0TnXCxh kXVxEiFpIjno1OSO4kFNuR4= X-Google-Smtp-Source: ABdhPJxS+wwoYNpj1opkB8I9CeMq2NQUgK1QlZniXxUjfncUuY9adyALHi2nQ/bHtUdr/FV4X614uw== X-Received: by 2002:a17:90a:6b0d:: with SMTP id v13mr1511086pjj.138.1634764628750; Wed, 20 Oct 2021 14:17:08 -0700 (PDT) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id p16sm3122835pgd.78.2021.10.20.14.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 14:17:07 -0700 (PDT) Date: Thu, 21 Oct 2021 06:17:05 +0900 To: Tom Tromey Subject: Re: [PATCH 1/5] gdb: or1k: implement gdb server Message-ID: References: <20210913124800.471680-1-shorne@gmail.com> <20210913124800.471680-2-shorne@gmail.com> <87mtn3vbwq.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mtn3vbwq.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Stafford Horne via Gdb-patches Reply-To: Stafford Horne Cc: Openrisc , Stafford Horne via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Wed, Oct 20, 2021 at 11:33:41AM -0600, Tom Tromey wrote: > >>>>> ">" == Stafford Horne via Gdb-patches writes: > > >> This patch adds gdbserver support for OpenRISC. This has been used for > >> debugging the glibc port that in being worked on here: > > >> https://github.com/openrisc/or1k-glibc/tree/or1k-port-2 > > >> Hence the comment about registers definitions being inline with glibc. > > Thanks for the patch. I had one minor comment. > > >> +#define or1k_breakpoint_len 4 > > >> +bool > >> +or1k_target::low_breakpoint_at (CORE_ADDR where) > >> +{ > >> + unsigned int insn; > >> + > >> + read_memory (where, (unsigned char *) &insn, 4); > > Perhaps this ought to use or1k_breakpoint_len here. Right, I will update that before pushing. > >> +/* Fetch the thread-local storage pointer for libthread_db. */ > >> + > >> +ps_err_e > >> +ps_get_thread_area (struct ps_prochandle *ph, > >> + lwpid_t lwpid, int idx, void **base) > >> +{ > > Not your problem but it seems like a shame that this exact > implementation is repeated several times in gdbserver. I agree. -Stafford