From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Luis Machado <luis.machado@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix build failure for 32-bit targets
Date: Fri, 1 Oct 2021 11:25:41 -0400 [thread overview]
Message-ID: <YVcodZX1VM8rgyfQ@vapier> (raw)
In-Reply-To: <20211001115002.1681134-1-luis.machado@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
On 01 Oct 2021 08:50, Luis Machado via Gdb-patches wrote:
> When building master GDB, I ran into the following:
>
> binutils-gdb/gdb/bt-utils.c: In function ‘int libbacktrace_print(void*, uintptr_t, const char*, int, const char*)’:
> binutils-gdb/gdb/bt-utils.c:93:44: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uintptr_t {aka unsigned int}’ [-Werror=format=]
> snprintf (buf, sizeof (buf), "0x%lx ", pc);
>
> Fix this by using phex and %s as opposed to 0x%lx.
wouldn't PRIxPTR fix it and be simpler ?
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-01 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 11:50 Luis Machado via Gdb-patches
2021-10-01 15:25 ` Mike Frysinger via Gdb-patches [this message]
2021-10-01 15:53 ` Luis Machado via Gdb-patches
2021-10-01 16:08 ` Simon Marchi
2021-10-01 16:11 ` Simon Marchi
2021-10-01 16:32 ` Luis Machado via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVcodZX1VM8rgyfQ@vapier \
--to=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox