From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iA5aCd64OWEKegAAWB0awg (envelope-from ) for ; Thu, 09 Sep 2021 03:33:50 -0400 Received: by simark.ca (Postfix, from userid 112) id 0DCF81EE23; Thu, 9 Sep 2021 03:33:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5BE341EDDB for ; Thu, 9 Sep 2021 03:33:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ABE49384B0D3 for ; Thu, 9 Sep 2021 07:33:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ABE49384B0D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631172828; bh=+TddaQV5bzhulCgySVdGaqRPce82sfQc9zzzfwrhcec=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Gh5DYRCoAnik0mJGgicF51B6vWDDppaAQequURU1cN768FHuVRjpOydhJDFYPX2oe WNeHMR36AsIIwT3oTA4mvsldw+xsZ5x8mciRuLrt1w0W7+y1GaDi0mUiRwISqJYilB wSY7IMcVtv9JGn7Eo+CQncCTbXOKNAOFgnKTvkgs= Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id B8765384C002 for ; Thu, 9 Sep 2021 07:33:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8765384C002 Date: Thu, 9 Sep 2021 03:33:23 -0400 To: Eli Zaretskii Subject: Re: [PATCH 2/2] sim: use gnulib to set nonblocking mode Message-ID: Mail-Followup-To: Eli Zaretskii , gdb-patches@sourceware.org References: <20210909063836.16875-1-vapier@gentoo.org> <20210909063836.16875-2-vapier@gentoo.org> <837dfqky8t.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0Gn+wn0jJYZahv06" Content-Disposition: inline In-Reply-To: <837dfqky8t.fsf@gnu.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --0Gn+wn0jJYZahv06 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 09 Sep 2021 10:24, Eli Zaretskii wrote: > > Date: Thu, 9 Sep 2021 02:38:36 -0400 > > From: Mike Frysinger via Gdb-patches > >=20 > > Replace various custom ad-hoc fcntl/O_NONBLOCK implementations with > > the gnulib nonblocking module. This makes our code much tidier and > > portable to other systems (e.g. Windows). >=20 > I'm not familiar with the sim's code, but Gnulib AFAIK supports > non-blocking flag on MinGW only for named pipes and sockets, not for > real files. Are all the file descriptors in the places where you make > the changes of one of those kinds? E.g., I see the fcntl calls on > file descriptor zero in some places. sim only uses nonblocking on sockets or tty's (e.g. stdin), not files on di= sk. i don't know offhand about the specifics of Windows stdio and whether those= are actually pipes. -mike --0Gn+wn0jJYZahv06 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmE5uMMACgkQQWM7n+g3 9YFDFQ//XHjopL7a2uJZFlVF+7PuCwC2dBTRgQLdGpkhx7Q8WfzdVBZ8a53sp7/r +CVZkN6wOhWjE9cRLpXPNBseXVsStjUSd32M1VzT5xmzRJ8mu1Ra8ZkZJkeQN5zx oT0wIi5Hmg2jp1UiTzRVo5qCRyxgR9Kd+ESYJMFdwUb39xk5ieSSBOQZUOHX3Jd/ k1Yvd7zwZWjQpIB87vej5CRhzqD+6Pm8El/bJ/wYsTY+qI9umL87QhI7oQWBEkDo Yt2EMmo9WxaiF7SGu8qPAO0VPKlbKtVDgPuTQtB6AqmzjgoZasauEzdt3LNoRPI1 KAi0RLiKJ0H1c87dHIAIc+WeGD6zYMcxLnidfx4h3rTHaJxRLxfWRK1c7nmrxK1v 6NLMAPgpFeqEPZHwrxDVxKVfF6j2/WsgVWvb0KM2x2terqDIAR/FTRb7WjJwDyXf mBKkBVvkZzmslGNdP9LhB7JlXlxTUsHNjJ2ETpzW9yptgG2/Wd/BQOd4cRyIMC4K vWYj6qshg2UC6yd1ie0sBCSU+ieDryx/umT8FgJ9hFyYpouuaAuXOU31mMvJ/Bq7 3VW8886R7OuKZ26aNQfvZjWmQGY5QR8c+RRLHjKeCiw2rZ42f06JukDqe58uuHvt BFBLz/cF78DbmTYcSi0RMpzaRINSkH4150LTD54Hhae0Hfr4emA= =Q2uR -----END PGP SIGNATURE----- --0Gn+wn0jJYZahv06--