From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] gdb: cris: enable sim integration
Date: Tue, 7 Sep 2021 22:33:23 -0400 [thread overview]
Message-ID: <YTgg8yoG1eed4kF8@vapier> (raw)
In-Reply-To: <7e2ba1b5-d825-96f3-e727-b9b9f540e661@polymtl.ca>
[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]
On 07 Sep 2021 10:40, Simon Marchi wrote:
> On 2021-08-19 5:23 p.m., Mike Frysinger via Gdb-patches wrote:
> > The sim side is already ready to go for cris, so wire it up.
> > ---
> > gdb/configure.tgt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/gdb/configure.tgt b/gdb/configure.tgt
> > index 55ae7541b619..c678027faef4 100644
> > --- a/gdb/configure.tgt
> > +++ b/gdb/configure.tgt
> > @@ -743,6 +743,7 @@ arm*-*-*) gdb_sim=arm ;;
> > avr*-*-*) gdb_sim=avr ;;
> > bfin-*-*) gdb_sim=bfin ;;
> > bpf-*-*) gdb_sim=bpf ;;
> > +cris-*-*|cris32-*-*) gdb_sim=cris ;;
> > frv-*-*) gdb_sim=frv ;;
> > ft32-*-*) gdb_sim=ft32 ;;
> > h8300*-*-*) gdb_sim=h8300 ;;
> >
>
> Any reason not to use
>
> cris*-*-*
>
> similar to other arches?
the two cris tuples here are what's used throughout the tree. i don't have
an opinion on it in general, but having gdb match the rest of the tree seems
like the best bet. i get that earlier in this file it does "cris*". maybe
the cris maintainers want to rectify this ? :)
$ grep 'cris-[*]' configure* */configure*
configure: cris-*-* | crisv32-*-*)
configure: cris-*-* | crisv32-*-*)
configure.ac: cris-*-* | crisv32-*-*)
configure.ac: cris-*-* | crisv32-*-*)
gas/configure: cris-*-*aout*) emulation="crisaout criself" ;;
gas/configure: cris-*-*) emulation="criself crisaout" ;;
gas/configure.ac: cris-*-*aout*) emulation="crisaout criself" ;;
gas/configure.ac: cris-*-*) emulation="criself crisaout" ;;
gas/configure.tgt: cris-*-linux-* | crisv32-*-linux-*)
gas/configure.tgt: cris-*-* | crisv32-*-*) fmt=multi ;;
ld/configure.tgt:cris-*-*aout*) targ_emul=crisaout
ld/configure.tgt:cris-*-linux-* | crisv32-*-linux-*)
ld/configure.tgt:cris-*-* | crisv32-*-*) targ_emul=criself
sim/configure: all|cris-*-* | crisv32-*-*)
sim/configure.ac: SIM_TARGET([cris-*-* | crisv32-*-*], [cris])
$ grep 'cris[*]' configure* */configure*
gdb/configure.tgt:cris*)
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-09-08 2:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 21:23 [PATCH 1/4] gdb: sim: consolidate configure settings Mike Frysinger via Gdb-patches
2021-08-19 21:23 ` [PATCH 2/4] gdb: aarch64: enable sim integration Mike Frysinger via Gdb-patches
2021-09-07 14:39 ` Simon Marchi via Gdb-patches
2021-08-19 21:23 ` [PATCH 3/4] gdb: cris: " Mike Frysinger via Gdb-patches
2021-09-07 14:40 ` Simon Marchi via Gdb-patches
2021-09-08 2:33 ` Mike Frysinger via Gdb-patches [this message]
2021-08-19 21:23 ` [PATCH 4/4] sim: update configure target list Mike Frysinger via Gdb-patches
2021-09-04 1:12 ` [PATCH 1/4] gdb: sim: consolidate configure settings Mike Frysinger via Gdb-patches
2021-09-07 14:39 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTgg8yoG1eed4kF8@vapier \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox