From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2FAtGCTOymA+HwAAWB0awg (envelope-from ) for ; Thu, 17 Jun 2021 00:23:00 -0400 Received: by simark.ca (Postfix, from userid 112) id 60DD81F163; Thu, 17 Jun 2021 00:23:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 18F981E01F for ; Thu, 17 Jun 2021 00:23:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CEC263853804 for ; Thu, 17 Jun 2021 04:22:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CEC263853804 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623903779; bh=Uizzw9gA+CMVxYQ7RFdVeJObX043G8YbG8wvwIBuJgw=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Luaw+ntRwLRg5aZUdmTTpqtA1lFUGPobkYjkE9cl0SWK6VxnInkP4FcdOr4kqS4FU 6KLf3bm4Tq0GfFKKjMQ9S/hGBrIpNm4j9zSGDn/MAlaojEgYKss4+OHpWkEohOWUOS H31nte7jCujONvYB6du9rmf0kFJxP5jCK2xVN8uY= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 2458F385702F for ; Thu, 17 Jun 2021 04:22:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2458F385702F Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 4D346340E3A; Thu, 17 Jun 2021 04:22:39 +0000 (UTC) Date: Thu, 17 Jun 2021 00:22:38 -0400 To: Simon Marchi Subject: Re: [PATCH/committed] sim: enable silent rules in common builds Message-ID: Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org References: <20210615000234.1211-1-vapier@gentoo.org> <0decd618-86e7-85db-5b95-db7454c07d61@polymtl.ca> <6750be05-09e1-e2d8-10be-e085071e540f@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6750be05-09e1-e2d8-10be-e085071e540f@polymtl.ca> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 16 Jun 2021 11:59, Simon Marchi via Gdb-patches wrote: > On 2021-06-14 9:43 p.m., Mike Frysinger wrote: > > On 14 Jun 2021 20:53, Simon Marchi via Gdb-patches wrote: > >> On 2021-06-14 8:52 p.m., Mike Frysinger wrote: > >>> On 14 Jun 2021 20:40, Simon Marchi wrote: > >>>> On 2021-06-14 8:02 p.m., Mike Frysinger via Gdb-patches wrote: > >>>>> We only do the common code as automake simplifies the logic. > >>>> > >>>> Are you interested in re-using what is done in GDB? I did this quickly > >>>> to show how it works. It covers maybe 90% of the commands with very little > >>>> effort. > >>> > >>> seems fine if you want to merge it ;) > >> > >> Ok, there's no issue in including the file directly from the gdb directory, > >> the sim/ directory is never released without gdb? > > > > currently not > > Ok, here's what I pushed. > > There are still a few non-silent rules, in particular I think we could > say "GEN foo" instead of showing the big shell command that generates > it. But I don't plan on doing it, the patch below already makes the > output easier to follow. yep, looks pretty good, thanks. maybe the 90% coverage will annoy me to fix the remaining rules if i can't unify them fast enough ;). -mike