From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VtieI4qvx2CPTgAAWB0awg (envelope-from ) for ; Mon, 14 Jun 2021 15:35:38 -0400 Received: by simark.ca (Postfix, from userid 112) id 83BA91F163; Mon, 14 Jun 2021 15:35:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3AF371E54D for ; Mon, 14 Jun 2021 15:35:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4A29396AC36 for ; Mon, 14 Jun 2021 19:35:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4A29396AC36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623699336; bh=FAUC2i1C+Nn96ZATOQiV3iN1kRRYo0gfIBvRz3eBnUA=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NwpYaIhLydgkPxduo/X0EocGmx9MwX+Z589vy0pcezvArig6F9szOhzwD8V0TCwYH w0YgawkZ2TRz2QSTGFAT1Y2DifxXOurASb5uK+oTXjM3DlFhwJQ9VuQ0WUrl73KT+C Aw/7pT6QcpU9tkGf6YA+9g1kYb74uF/bgFn9X+Dw= Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 60BD938515EB for ; Mon, 14 Jun 2021 19:35:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60BD938515EB Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 5A033335CD4; Mon, 14 Jun 2021 19:35:15 +0000 (UTC) Date: Mon, 14 Jun 2021 15:35:14 -0400 To: Eli Zaretskii Subject: Re: [PATCH] gnulib: import sys_wait Message-ID: Mail-Followup-To: Eli Zaretskii , gdb-patches@sourceware.org References: <20210613052519.19005-1-vapier@gentoo.org> <834ke07i7y.fsf@gnu.org> <83v96g5wxg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <83v96g5wxg.fsf@gnu.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 14 Jun 2021 17:43, Eli Zaretskii wrote: > > Date: Mon, 14 Jun 2021 10:35:07 -0400 > > From: Mike Frysinger > > Cc: gdb-patches@sourceware.org > > > > > AFAIU, this conflicts with what we have in gdbsupport/gdb_wait.h and > > > use in windows-nat.c and win32-low.cc. Worse, the Gnulib emulation of > > > this for Windows is (IMNSHO) less useful, since it doesn't support any > > > abnormal termination except the equivalent of SIGABRT (which causes > > > the Windows runtime to exit with status = 3). I tried to convince the > > > Gnulib folks to adopt a more useful emulation, similar to what we have > > > in gdb_wait.h, but AFAIR Bruno Haible rejected the idea. > > > > i don't think there's any conflicts. gdb* dirs probe the env w/out gnulib, > > so they'll see sys/wait.h is not available, and then the gdb_wait.h and such > > files will continue to be used. > > > > > Did you need this Gnulib module because those sims don't use > > > gdbsupport? And if so, is it possible to somehow avoid clashes > > > between this Gnulib module and what we have in gdb_wait.h? > > > > sim/ doesn't use gdbsupport/. the gdbsupport/ dir assumes it's used with > > only gdb/, and is C++, so i don't think trying to generalize it is worth > > the effort. > > OK, if there are no conflicts here, then apologies for the noise. (I > never build the sim subdirectory in my builds of GDB.) np, it's good to double check these nuances i've verified that gdb & gdbsupport don't detect sys/wait.h for a mingw build, and the gdb_wait file is compiled. i don't have a way of checking the gdb.exe though. -mike