From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6B9ZIVIJwWCOCgAAWB0awg (envelope-from ) for ; Wed, 09 Jun 2021 14:32:50 -0400 Received: by simark.ca (Postfix, from userid 112) id 85C381F163; Wed, 9 Jun 2021 14:32:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E63A31E813 for ; Wed, 9 Jun 2021 14:32:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2DB2639A5061 for ; Wed, 9 Jun 2021 18:32:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2DB2639A5061 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623263569; bh=GVuatDKIDO/oI2J76I79F8kMKtGnSMFtFKuv0kBv9yE=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=p6Hgi4kJ8YnCf2oSjGoWUVc5oiBBIVWKBY5/qku2B00Vdf8BKe/9I0sMTT6fnof0H jQoQHKshBPRaxH6eSDWRklwqX/wexlymEjdnAigKQqbn0DL2GnqqGqRtU+MBA4Gg0/ q95WqEUhtVLOzprHI9WgU9JPgZ68Mv7LrZcxLYxE= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id A513D39B3477 for ; Wed, 9 Jun 2021 18:32:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A513D39B3477 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D0A1E340A60; Wed, 9 Jun 2021 18:32:15 +0000 (UTC) Date: Wed, 9 Jun 2021 14:32:15 -0400 To: Pedro Alves Subject: Re: [PATCH 4/4] gnulib: import select Message-ID: Mail-Followup-To: Pedro Alves , Tom Tromey , Mike Frysinger via Gdb-patches References: <20210529172510.16285-1-vapier@gentoo.org> <20210529172510.16285-4-vapier@gentoo.org> <87bl8hn3y5.fsf@tromey.com> <46d0d024-1892-3584-3523-e8f5b2997630@palves.net> <44f44b32-0c9e-cdf0-69fa-f79a89295c04@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <44f44b32-0c9e-cdf0-69fa-f79a89295c04@palves.net> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Tom Tromey , Mike Frysinger via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 09 Jun 2021 19:12, Pedro Alves wrote: > On 2021-06-09 5:52 p.m., Mike Frysinger wrote: > > On 09 Jun 2021 13:27, Pedro Alves wrote: > >> I've always feared that gnulib's select module would conflict with that, > >> but I don't know for sure. In theory, we should be able to replace all > >> that code by using gnulib's select instead, though I'm not sure gnulib > >> handles some particulars like Ctrl-C interruption. > > > > why do you think it would conflict ? the file doesn't seem to use select() > > at all, and ser-mingw is always enabled for mingw targets. seems like the > > func would just be ignored. > > gnulib also sometimes replaces headers with their own incompatible > definitions. good point, but i'm not sure how that matters to ser-mingw specifically. it isn't including any select.h related headers, just Windows-specific ones. i haven't gone through that list (and indirect includes) explicitly. but i would expect the build to at least warn or fail if that were the case. did you have any specific concerns here ? or just aiming for due diligence with the testsuite to assuage general unease ? -mike