From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ctSiLTrzwGDSCAAAWB0awg (envelope-from ) for ; Wed, 09 Jun 2021 12:58:34 -0400 Received: by simark.ca (Postfix, from userid 112) id AC7411F163; Wed, 9 Jun 2021 12:58:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB3141E813 for ; Wed, 9 Jun 2021 12:58:33 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 55673399BC26 for ; Wed, 9 Jun 2021 16:58:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55673399BC26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623257913; bh=zk7CRRZKxdKHFypQJ3yCLDlHNB/OVfzwaKOuJ7gCruU=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=V+4zuP8RHnlrZTm2p83uFw2h2ZLWPiA7jwLRaZdhZkF/Tu7fjr3ewGZCWYBl3S7Ay GqKlbQrexhO/6OJz1b3W2hRApZ2N37qXV1MvHtC5ijDVtUwq0vosilImqwrfmBRVqm be8UQCs8QSDkIfFFPwNW4RC2x8nEpplAtL9TYWfA= Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 2FE15384841E for ; Wed, 9 Jun 2021 16:58:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2FE15384841E Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 11449340BD3; Wed, 9 Jun 2021 16:58:12 +0000 (UTC) Date: Wed, 9 Jun 2021 12:58:12 -0400 To: Tom Tromey Subject: Re: [PATCH] gnulib: allow control over srcdir Message-ID: Mail-Followup-To: Tom Tromey , Mike Frysinger via Gdb-patches References: <20210608220639.1975-1-vapier@gentoo.org> <87czsvjdr6.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87czsvjdr6.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Mike Frysinger via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 09 Jun 2021 08:47, Tom Tromey wrote: > >>>>> "Mike" == Mike Frysinger via Gdb-patches writes: > > Mike> The current setting assumes that gnulib is only used by dirs > Mike> immediately under the source root. Trying to build it two or > Mike> more levels deep fails. Add a variable so users can control. > > This is ok. i noticed an issue. upstream gnulib already uses GNULIB_SRCDIR in its bootstrap so people can export it in their env to point to the upstream gnulib git tree. if that's exported, then building gdb fails :/. since we can't assume GNU make, i was going to rename it to GNULIB_LOCAL_SRCDIR unless someone wants to bikeshed a diff name. > This file isn't actually used any more by gdb. seems to be ? gdb/Makefile.in & gdbserver/Makefile.in have: gdb/Makefile.in:GNULIB_BUILDDIR = ../gnulib gdb/Makefile.in:include $(GNULIB_BUILDDIR)/Makefile.gnulib.inc gdb/Makefile.in: $(INTL_CFLAGS) $(INCGNU) $(INCSUPPORT) $(ENABLE_CFLAGS) \ gdb/Makefile.in: $(WIN32LIBS) $(LIBGNU) $(LIBGNU_EXTRA_LIBS) $(LIBICONV) \ gdb/Makefile.in: $(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU) \ gdbserver/Makefile.in:GNULIB_BUILDDIR = ../gnulib gdbserver/Makefile.in:include $(GNULIB_BUILDDIR)/Makefile.gnulib.inc gdbserver/Makefile.in: -I$(srcdir)/../gdb $(INCGNU) $(INCSUPPORT) \ gdbserver/Makefile.in:gdbserver$(EXEEXT): $(sort $(OBS)) ${CDEPS} $(LIBGNU) $(LIBIBERTY) \ gdbserver/Makefile.in: -o gdbserver$(EXEEXT) $(OBS) $(GDBSUPPORT) $(LIBGNU) \ gdbserver/Makefile.in: $(LIBGNU_EXTRA_LIBS) $(LIBIBERTY) $(INTL) \ gdbserver/Makefile.in:gdbreplay$(EXEEXT): $(sort $(GDBREPLAY_OBS)) $(LIBGNU) $(LIBIBERTY) \ gdbserver/Makefile.in: $(GDBSUPPORT) $(LIBGNU) $(LIBGNU_EXTRA_LIBS) \ -mike