From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id buK6C/KjzmAGdwAAWB0awg (envelope-from ) for ; Sat, 19 Jun 2021 22:12:02 -0400 Received: by simark.ca (Postfix, from userid 112) id 2873C1F163; Sat, 19 Jun 2021 22:12:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A19D71E813 for ; Sat, 19 Jun 2021 22:12:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED6AA383D80B for ; Sun, 20 Jun 2021 02:12:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED6AA383D80B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624155121; bh=NkGbxd+3UJZa3IKxJJGs0MYoCVgh/dSHtfWGGK+l32U=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=o/rhN75EQ8+KhbjH9PtUoRwmF2Vfj/daLDVZKNZA2PonB7HMYKZ7HxgEMHohV0aBV t8VWEtoNt1VN6C+EijO3q7rR1dlYTG0hOxoK6zcXc4nj/EJ9poQ/VvnUy7ufbdZSLB J/BLtsP1RHYzgXJ9gxLCUIT2ZdS7PY91oVlab0KU= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 799D238515EC for ; Sun, 20 Jun 2021 02:10:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 799D238515EC Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id A5ACE335DC6; Sun, 20 Jun 2021 02:10:24 +0000 (UTC) Date: Sat, 19 Jun 2021 22:10:24 -0400 To: Simon Marchi Subject: Re: [PATCH v2] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS Message-ID: Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org References: <20210615054416.1232-1-vapier@gentoo.org> <20210618140342.16460-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 19 Jun 2021 20:48, Simon Marchi wrote: > On 2021-06-18 10:03 a.m., Mike Frysinger via Gdb-patches wrote: > > These dirs don't use automake, so use AC_CONFIG_MACRO_DIRS to specify > > ../config as a search dir for m4 macros. This allows removal of a lot > > of hand-written m4_include's from acinclude.m4 files, and simplifies > > use of `aclocal` or `autoreconf` as manual -I is not needed. > > --- > > v2: include comment in top of acinclude.m4 files. > > With this patch, I get: > > configure.ac:531: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd > ../config/iconv.m4:12: AM_ICONV_LINKFLAGS_BODY is expanded from... > ../config/iconv.m4:23: AM_ICONV_LINK is expanded from... > ../config/iconv.m4:104: AM_ICONV is expanded from... > configure.ac:531: the top level > configure.ac:531: warning: AC_LIB_RPATH is m4_require'd but not m4_defun'd > ../config/iconv.m4:12: AM_ICONV_LINKFLAGS_BODY is expanded from... > ../config/iconv.m4:23: AM_ICONV_LINK is expanded from... > ../config/iconv.m4:104: AM_ICONV is expanded from... > configure.ac:531: the top level > > To fix this, we'd need to keep these three lines: > > m4_include(../config/lib-ld.m4) > m4_include(../config/lib-prefix.m4) > m4_include(../config/lib-link.m4) > > If I bring them back, it's all clean. just in gdb/ right ? you're running `autoreconf` to test ? -mike