From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LK5VDTHSqWBIKAAAWB0awg (envelope-from ) for ; Sat, 22 May 2021 23:55:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 1EB1E1F11C; Sat, 22 May 2021 23:55:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CE2751E783 for ; Sat, 22 May 2021 23:55:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F4CF383541F; Sun, 23 May 2021 03:55:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F4CF383541F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621742127; bh=lGHoO/Oe93x3EEjbVWFRhaApXypwPwrYxDEbe+Go/0k=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=qm1+MQQKOxsZ7Cp8dGwA2fwMUkeerW5BEa9wBeEbX5QoA/mr6wi1eg/wWVG9KzBeO PX1sxxmc6vcfA6mLwVwoBCrjpgtLxwKZUDmbrrcnHOQk6DaPkEP4Zx4ON1TLbp/4To 4WEytRAktG5qnrad6eDarjS7kFxyN2eN7VkDZ8DA= Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id CA6D2385483B; Sun, 23 May 2021 03:55:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CA6D2385483B Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 9CA8C335C85; Sun, 23 May 2021 03:55:22 +0000 (UTC) Date: Sat, 22 May 2021 23:55:21 -0400 To: Hans-Peter Nilsson Subject: Re: [PATCH] opcodes: cris: move desc & opc files from sim/ Message-ID: Mail-Followup-To: Hans-Peter Nilsson , binutils@sourceware.org, gdb-patches@sourceware.org References: <20210519212626.58A6A203C3@pchp3.se.axis.com> <20210519213237.8C6CA203C1@pchp3.se.axis.com> <20210519234827.86E7C203C6@pchp3.se.axis.com> <20210520132100.0F5A2203C7@pchp3.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210520132100.0F5A2203C7@pchp3.se.axis.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 20 May 2021 15:21, Hans-Peter Nilsson wrote: > From: Mike Frysinger > > On 20 May 2021 01:48, Hans-Peter Nilsson wrote: > > > From: Mike Frysinger > > > > On 19 May 2021 23:32, Hans-Peter Nilsson wrote: > > > > > From: Hans-Peter Nilsson > > > > > > From: Mike Frysinger via Binutils > > > > > > > All other cgen ports keep their desc & opc files under opcodes/, so > > > > > > > move the cris files over too. The cris-opc.c file is already here. > > > > > > > > > > > > Unline (most) other CGEN ports, the assembler and > > > > > > disassembler isn't generated from the CGEN description. But > > > > > > that's not a reason to keep it different in this regard. > > > > > > > > > > > > Ok with the appropriate opcodes/ChangeLog entry. Thanks! > > > > > > > > > > No, wait, NOT ok: cris-opc.c isn't CGEN-generated. Please > > > > > fix so it isn't "regenerated". > > > > > > > > you want me to delete the cris cgen rule entirely ? > > > > > > "No" if you mean removing the regeneration rule for the > > > CGEN-generated CRIS files of course. > > > > > > But, if you want to move the CRIS CGEN files to opcodes/, > > > there must be precautions to not overwrite the cris-opc.c > > > there. > > > > from what i can tell, the opcodes/ script has no support for only generating > > a single file. it wants to do them all. so you want me to pull the desc > > logic out of sim/common/cgen.sh and into opcodes/cgen.sh so that cris can run > > that logic ? > > I want you to do something, if anything, that works for CRIS > sim *and* binutils. If your suggestion is sane to you, then > perhaps yes, but as the CGEN files aren't used for CRIS > binutils, leaving things as they are in sim may be even > simpler. the desc & opc files are tightly coupled with the BFD & opcodes APIs. they break with changes i'm trying to make to sim. they need to get moved out. > > it's hard to test as the cris cgen rules fail for me even now with syntax > > errors in the scm files. > > Badness. CGEN as in using sim/common/cgen.sh? Is there an > issue entered in bugzilla? I guess someone has been naughty > and didn't test a CGEN change properly. seems like it's the opposite. cgen is stuck on guile-1.8 even though distros have moved on to 2.0+. -mike