Re: [PATCH v2 1/2] sim: h8300 Fixed different behavior in preinc/predec.

Mike Frysinger via Gdb-patches
2021-05-25T23:10:06Z

On 25 May 2021 23:10, Yoshinori Sato wrote:

just nits. looks fine otherwise, although i'm no h8300 expert.

> + case OP_PREINC:
> + if (OP_KIND(dst->opcode) == O_MOV)

space before the (

> + case X (OP_REG_DEC, SB): /* Register direct, affected decrement byte. */
> + *val = GET_B_REG (rn) - 1;
> + break;
> + case X (OP_REG_DEC, SW): /* Register direct, affected decrement word. */
> + *val = GET_W_REG (rn) - 2;
> + break;
> + case X (OP_REG_DEC, SL): /* Register direct, affected decrement long. */
> + *val = GET_L_REG (rn) - 4;
> + break;
> + case X (OP_REG_INC, SB): /* Register direct, affected increment byte. */
> + *val = GET_B_REG (rn) + 1;
> + break;
> + case X (OP_REG_INC, SW): /* Register direct, affected increment word. */
> + *val = GET_W_REG (rn) + 2;
> + break;
> + case X (OP_REG_INC, SL): /* Register direct, affected increment long. */
> + *val = GET_L_REG (rn) + 4;
> + break;

2 spaces after those . in the comment
-mike