From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MOYjOWmIkWBeaAAAWB0awg (envelope-from ) for ; Tue, 04 May 2021 13:46:17 -0400 Received: by simark.ca (Postfix, from userid 112) id E816D1F11C; Tue, 4 May 2021 13:46:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 568C81E01F for ; Tue, 4 May 2021 13:46:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B69CE39CE436; Tue, 4 May 2021 17:46:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B69CE39CE436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620150376; bh=nqKPUx1Gb3G/rGHGnMt4w9VHZxieKzPN/9k21+PeECI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cnbXnvYyihDT12NBYULVUMYHKLViHjacIZtg76QVDxCTcLdC85dLUr2WWXh/heRbQ 4UtpdNtFUKrjGDZYJDTBJfvofQPe4FAJvhaSyF3guhpyfv1bIxm1Tc8zRwbP22mAu4 h39zv3VJn0u73aiCrjOqQv/sN/J38XPG2QlorQnI= Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 29A0E3959E40 for ; Tue, 4 May 2021 17:46:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 29A0E3959E40 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 518F9335C2A; Tue, 4 May 2021 17:46:13 +0000 (UTC) Date: Tue, 4 May 2021 13:46:13 -0400 To: Tom Tromey Subject: Re: [PATCH] gnulib: import getline Message-ID: Mail-Followup-To: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org References: <20210501220936.30972-1-vapier@gentoo.org> <533969a7-d2fe-cdbd-40dc-e77eab30a469@polymtl.ca> <9b1cfe9d-2366-f626-f555-3ee5a99cddbc@polymtl.ca> <874kfituax.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <874kfituax.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 04 May 2021 09:03, Tom Tromey wrote: > >>>>> "Mike" == Mike Frysinger via Gdb-patches writes: > > Mike> gnulib: import getline > > Mike> We use getline in sim today which breaks on older systems that are > Mike> not compliant with the latest POSIX standard. For example, Windows > Mike> (mingw) omits getline so we fail to build there. > > Thanks. This looks good with this update. pushed > I saw this build problem internally at AdaCore today, so I appreciate > the quick fix. which subdir & target are you seeing issues with ? is it sim on Windows ? or is it some other combo ? -mike