From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FHAAGlPsgGBITAAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 23:24:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 5DB121F104; Wed, 21 Apr 2021 23:24:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C81CA1E54D for ; Wed, 21 Apr 2021 23:24:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48ECA3857C74; Thu, 22 Apr 2021 03:24:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48ECA3857C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619061842; bh=EPAAqQlFlswgMU2YG5xEVdjrpK+hAvJyPfsiwy7vSrY=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F3rzG6IxuUfdsnjrOsBE4wUT6HMfcmdEVOomO6oUbsmPgRqw/tvQuP85OWYqrHFlD L4m1+nmEzbxi5u5rsp1w/uANWKYWP3tHiuxVqAefCyBTkJ4Ab/4tTWvKK4Pkh67Lch jBVh1LfDzKRjGLAZ//CRSqRE1bgU90Q4PuAAmmVE= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 263B1385802A for ; Thu, 22 Apr 2021 03:24:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 263B1385802A Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 64E8B34110B; Thu, 22 Apr 2021 03:23:59 +0000 (UTC) Date: Wed, 21 Apr 2021 23:23:58 -0400 To: Jim Wilson Subject: Re: [PATCH 09/24] RISC-V sim: Fix syscall fallback. Message-ID: Mail-Followup-To: Jim Wilson , gdb-patches@sourceware.org, Kito Cheng References: <20210417175831.16413-1-jimw@sifive.com> <20210417175831.16413-10-jimw@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Kito Cheng , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 21 Apr 2021 16:38, Jim Wilson wrote: > This one is missing a review. there's a lot to unpack in this series :). i figured we'd merge the ones we def agree on, then respin the series with the ones left. it makes it a bit easier to iterate when there's fewer things to look at all at once, both in terms of scope, and in terms of patch count. i'm hoping we can avoid forking the syscall handling logic by implementing all the syscalls you want in the common code, thus this particular patch wouldn't be necessary. i'm not 100% confident we can get there, but i think it's worth trying. -mike