From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3jdsGaMvjmAEGAAAWB0awg (envelope-from ) for ; Sun, 02 May 2021 00:50:43 -0400 Received: by simark.ca (Postfix, from userid 112) id 5AA7C1F11C; Sun, 2 May 2021 00:50:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A57111E783 for ; Sun, 2 May 2021 00:50:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0FA993844025; Sun, 2 May 2021 04:50:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0FA993844025 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619931042; bh=GFvXRWnfyNscKTVUk3fcBOC8JT/+IiUYlgQ7jv1ifwY=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YCBPDinZ0pOStXUtLOZsB/SqnHvgEYsdjfv3dhMfnE1NGJLbXmxq2XYzA4R/XrorC 4555AXmUhRmA2Uer7KFzukr9R7qjWklvbziHKUD4YtMJRB9vSue45aAfPxB8rwX1ze 8gXsn3taPt8DhDeq5k/Fq/yvONA+phexRj72zXys= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 1531B3844025 for ; Sun, 2 May 2021 04:50:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1531B3844025 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 25AF6335D74; Sun, 2 May 2021 04:50:39 +0000 (UTC) Date: Sun, 2 May 2021 00:50:38 -0400 To: Simon Marchi Subject: Re: [PATCH] gnulib: import getline Message-ID: Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org References: <20210501220936.30972-1-vapier@gentoo.org> <533969a7-d2fe-cdbd-40dc-e77eab30a469@polymtl.ca> <9b1cfe9d-2366-f626-f555-3ee5a99cddbc@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9b1cfe9d-2366-f626-f555-3ee5a99cddbc@polymtl.ca> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 01 May 2021 20:49, Simon Marchi via Gdb-patches wrote: > On 2021-05-01 8:46 p.m., Mike Frysinger wrote: > > On 01 May 2021 20:39, Simon Marchi wrote: > >> On 2021-05-01 6:09 p.m., Mike Frysinger via Gdb-patches wrote: > >>> We use getline in sim today which breaks on older systems that are > >>> compliant with the latest POSIX standard. > >> > >> I can't really parse that sentence. Using getline doesn't work on older > >> systems, because those older systems are compliant with the latest POSIX > >> standard? Huh? Wouldn't being compliant with the latest POSIX standard > >> be a good thing? > > > > sorry, meant "not compliant". getline is in POSIX, but not all targets > > support it. e.g. Windows (mingw) omit it. > > Ah ok, that makes more sense, thanks. Still, please mention the > specific platform in the commit message. I always understand better > with a concrete example. sure, that's np. gnulib: import getline We use getline in sim today which breaks on older systems that are not compliant with the latest POSIX standard. For example, Windows (mingw) omits getline so we fail to build there.