From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-bounces@sourceware.org>
Received: from simark.ca
	by simark.ca with LMTP
	id F/T1OocCfWAOZgAAWB0awg
	(envelope-from <gdb-patches-bounces@sourceware.org>)
	for <public-inbox@simark.ca>; Mon, 19 Apr 2021 00:09:43 -0400
Received: by simark.ca (Postfix, from userid 112)
	id E7C681F104; Mon, 19 Apr 2021 00:09:43 -0400 (EDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.2
Received: from sourceware.org (server2.sourceware.org [8.43.85.97])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPS id 771FC1E813
	for <public-inbox@simark.ca>; Mon, 19 Apr 2021 00:09:43 -0400 (EDT)
Received: from server2.sourceware.org (localhost [IPv6:::1])
	by sourceware.org (Postfix) with ESMTP id 07F913952DAC;
	Mon, 19 Apr 2021 04:09:43 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07F913952DAC
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1618805383;
	bh=6utjEq2hDNE51rW66h9Xzr7LdarT43cJGWeMhUjJGls=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=t7m2okyNufZcp7oF1aPv6dUC8dAu3/MWYzSjXSsy5GfXdZK8DEHk/BLXYW/7KSqA+
	 XDOrE67MMlsn5FAXVQUPNmAL6KYXnnMOaovgbQQFxRWK/1L6pmzadeTSO7OVNDdpx8
	 GpSg1B8TixfWkVyf9UivcUQkEgSGPv86/gtubdI4=
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
 by sourceware.org (Postfix) with ESMTP id F14AA3952DAC
 for <gdb-patches@sourceware.org>; Mon, 19 Apr 2021 04:09:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F14AA3952DAC
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 2AA76340E13;
 Mon, 19 Apr 2021 04:09:40 +0000 (UTC)
Date: Mon, 19 Apr 2021 00:09:39 -0400
To: Jim Wilson <jimw@sifive.com>
Subject: Re: [PATCH 07/24] RISC-V sim: Add link syscall support.
Message-ID: <YH0CgxVMRCRmk8s1@vapier>
Mail-Followup-To: Jim Wilson <jimw@sifive.com>, gdb-patches@sourceware.org,
 Kuan-Lin Chen <rufus@andestech.com>
References: <20210417175831.16413-1-jimw@sifive.com>
 <20210417175831.16413-8-jimw@sifive.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210417175831.16413-8-jimw@sifive.com>
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
Reply-To: Mike Frysinger <vapier@gentoo.org>
Cc: Kuan-Lin Chen <rufus@andestech.com>, gdb-patches@sourceware.org
Errors-To: gdb-patches-bounces@sourceware.org
Sender: "Gdb-patches" <gdb-patches-bounces@sourceware.org>

On 17 Apr 2021 10:58, Jim Wilson wrote:
> -      cpu->a0 = sim_syscall (cpu, cpu->a7, cpu->a0, cpu->a1, cpu->a2, cpu->a3);
> +      if (cb_target_to_host_syscall (STATE_CALLBACK (sd), cpu->a7) == -1)
> ...
> +	    case TARGET_SYS_link:

why not implement this in common/syscall.c so all ports can benefit ?
-mike