Re: [PATCH] sim/m32c: fix memory leaks in opc2c

[Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>]

On 05 Apr 2021 10:58, Simon Marchi via Gdb-patches wrote:
> Fix the leak in dump_lines by free-ing the elements of varnames.

i dislike stuffing a bunch of free's at the end of a program's lifetime just
to satisfy a tool that is not normally used.  which isn't to say LSAN isn't
useful, just that i think we should do better.

in other codebases, i've done things like:
#ifdef __SANITIZE_ADDRESS__
# define ENABLE_CLEANUP_ONEXIT 1
#else
# define ENABLE_CLEANUP_ONEXIT 0
#endif

then this could be written:

if (ENABLE_CLEANUP_ONEXIT) {
  for (i = 0; i < vn; i++)
    free (varnames[i]);
}

wdyt ?  feel free to bikeshed the name.  not sure if there's prior art in
the tree currently.
-mike