Re: [PATCH 1/2] sim: testsuite: Get common tests compiling again

[Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>]

On 01 Feb 2021 15:44, Stafford Horne via Gdb-patches wrote:
> On Sun, Jan 31, 2021 at 10:15:02PM -0500, Mike Frysinger wrote:
> > On 05 Oct 2017 23:17, Stafford Horne wrote:
> > > This is a series of changes to the the old and non working sim common
> > > testsuite .  As far as I can tell this has not been used since what
> > > looks like before 64-bit desktop computers became common.  Most of the
> > > changes here are to convert the test code to be 64-bit portable.
> > 
> > sorry for not seeing this sooner.  i stumbled across this dir myself
> > recently and came to the same conclusions you did (about the non-fpu
> > stuff).  i pushed some fixes to get it working on my 64-bit desktop.
> > 
> > i haven't tried to integrate the build though.  i was going to let
> > that wait until we had better overall build integration than add some
> > more subdir-configure scripts, then should be able to revisit.
> 
> OK.
> 
> > > The fpu-tst tool actually depends on external code from v2 of berkeley
> > > softfloat [1] and testfloat [2] libraries which I cleaned up so the
> > > would actually build on a modern compiler.  The build will generate a
> > > 'testfloat' binary which will be used to compare the sim-fpu vs the
> > > softfloat implementation.
> > 
> > ah, very cool.  i saw those includes and thought those were weird but
> > then gave up on trying to track them down.  i assumed it was some weird
> > thing that didn't exist anymore.
> > 
> > can you refresh these and see how many are still needed ?  i think the
> > alu-tst & bits-gen & bits-tst files should be all set now in the latest
> > tree.  for the fpu-tst, how about we put the details/comments into the
> > source file itself for now ?
> 
> Sure, it will take me some time to get done.

i've done a bit more work in here and the tests are part of `make check` now.
hopefully the new sim/testsuite/common/local.mk is easier to work with.
-mike