Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Binutils <binutils@sourceware.org>, gdb-patches@sourceware.org
Subject: Re: Please enable fast forward for user branches
Date: Tue, 30 Mar 2021 01:36:20 -0400	[thread overview]
Message-ID: <YGK41DFaIxhEGjOM@vapier> (raw)
In-Reply-To: <20210330040939.GC11111@adacore.com>

On 30 Mar 2021 08:09, Joel Brobecker wrote:
> > I would like to sync up my binutils user branches to the primary server.
> > However, I can't do rebases which makes it not usable at all:
> > 
> > $ git push origin me/startswith -f
> > Enumerating objects: 257, done.
> > Counting objects: 100% (257/257), done.
> > Delta compression using up to 16 threads
> > Compressing objects: 100% (140/140), done.
> > Writing objects: 100% (140/140), 22.31 KiB | 951.00 KiB/s, done.
> > Total 140 (delta 134), reused 0 (delta 0), pack-reused 0
> > remote: Resolving deltas: 100% (134/134), completed with 117 local objects.
> > remote: error: denying non-fast-forward refs/heads/users/marxin/startswith (you should pull first)
> > To ssh://sourceware.org/git/binutils-gdb.git
> >  ! [remote rejected]         me/startswith -> users/marxin/startswith (non-fast-forward)
> > error: failed to push some refs to 'ssh://sourceware.org/git/binutils-gdb.git'
> 
> I think the error above comes from Git itself, and is related
> to the configuration of the repository. In particular, I found
> that our binutils-gdb repository's configuration has:
> 
> | [receive]
> |         denynonfastforwards = true
> 
> Not sure what the history of this is.
> 
> In the meantime, I've modified the git-hooks configuration so that,
> if the above is lifted, users will be allowed to do non-fast-forward
> updates on users/.* branches.

iiuc, out of the box, the default git implementation has one knob for all
branches (the one you found).  we set it that way so people don't push
non-fast-forwards to the important branches (e.g. "master" or any of the
many release branches).  that all makes perfect sense -- we don't want
people to accidentally, or on purpose, rewrite (i.e. rewind) history once
it's gone public.

unfortunately, the default git configs don't have ref filtering to allow
denynonfastforwards=false on refs/heads/users/*.  any services that have
that functionality implemented it themselves.  which is what we'd have to
do with custom git hooks if we wanted to.  but it looks like no one has
volunteered to implement the hook to block most refs by default but only
allow a specific subset.  probably because they don't want to be on the
hook for when it needs debugging.
-mike

  reply	other threads:[~2021-03-30  5:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1af95023-580d-6774-c307-1a38bf3dc073@suse.cz>
2021-03-30  4:09 ` Joel Brobecker
2021-03-30  5:36   ` Mike Frysinger via Gdb-patches [this message]
2021-03-30  6:17     ` Joel Brobecker
2021-03-30 11:53       ` Mike Frysinger via Gdb-patches
2021-03-30 12:52         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGK41DFaIxhEGjOM@vapier \
    --to=gdb-patches@sourceware.org \
    --cc=binutils@sourceware.org \
    --cc=brobecker@adacore.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox