From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sGDJB29ub2BBHQAAWB0awg (envelope-from ) for ; Thu, 08 Apr 2021 16:58:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 1D94E1EE0E; Thu, 8 Apr 2021 16:58:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 909BA1E590 for ; Thu, 8 Apr 2021 16:58:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0DF413955C09; Thu, 8 Apr 2021 20:58:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DF413955C09 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617915502; bh=QIkCU/RRDZKLzR5PwQg1/yoyw0jQX59BsRFWSorqFBE=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lzcu3B76wY71EEWekwOlY7r3lBFWCYG5ldeCXU6vANLR2UFgWWwLCeeNUlTesyXUL DuQPclMUFzMBMLTyAV/XWzT20vcgLI6bWjVVMitIDuGFuOm83NgM7CSDQx+fQto7l+ ICQdjlqYzxZW5PS8eLz6ONIXTYrshYBpNhMjtavc= Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 5B4CD3857033 for ; Thu, 8 Apr 2021 20:58:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B4CD3857033 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 867D8340D67; Thu, 8 Apr 2021 20:58:19 +0000 (UTC) Date: Thu, 8 Apr 2021 16:58:18 -0400 To: Tom Tromey Subject: Re: [PATCH 2/2] Add system includes in sim Message-ID: Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20210408164436.2165323-1-tom@tromey.com> <20210408164436.2165323-3-tom@tromey.com> <87y2dsk4og.fsf@tromey.com> <87wntch5wo.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87wntch5wo.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 08 Apr 2021 14:34, Tom Tromey wrote: > >>>>> "Tom" == Tom Tromey writes: > > >>> * func.c: Include sys/time.h. > Mike> this one isn't in C99. we seem to sometimes protect against it, but not > Mike> always. if we go by gnulib's notes, it seems like we should just assume > Mike> it everywhere. wdyt ? > Mike> https://www.gnu.org/software/gnulib/manual/html_node/sys_002ftime_002eh.html#sys_002ftime_002eh > > Tom> Makes sense to me. > > I'm going to go ahead & check in both of these. of course, thanks -mike