From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rFslJ8Fjb2BSGwAAWB0awg (envelope-from ) for ; Thu, 08 Apr 2021 16:12:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 9211A1EE0E; Thu, 8 Apr 2021 16:12:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D8DD31E590 for ; Thu, 8 Apr 2021 16:12:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 621D83857033; Thu, 8 Apr 2021 20:12:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 621D83857033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617912768; bh=GVgpzK/eoFtkkX0Hrq0VffBU76C189dGsvUlumhP+js=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=I/FVJvZcRuhSwpw/F/Ahf2XQ1IPlKY/74bbjiH55NGaBIyxL9RVfGk1n04i+ajqxE hk9WNI05Ux9APA1j4wOv+hy8NEpWUG6gsZjsXKJ9swNcDVkQE1y7lFC6FHqoY5mjlR phnUIX6RvmyMnkYKpGxnOCgtrzLMSWS2ct1AfSPk= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id D382C39551C5 for ; Thu, 8 Apr 2021 20:12:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D382C39551C5 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 9D6DB335D2C; Thu, 8 Apr 2021 20:12:44 +0000 (UTC) Date: Thu, 8 Apr 2021 16:12:43 -0400 To: Tom Tromey Subject: Re: [PATCH 2/2] Add system includes in sim Message-ID: Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20210408164436.2165323-1-tom@tromey.com> <20210408164436.2165323-3-tom@tromey.com> <87y2dsk4og.fsf@tromey.com> <87lf9sk20m.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87lf9sk20m.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 08 Apr 2021 13:30, Tom Tromey wrote: > >>>>> "Mike" == Mike Frysinger writes: > > Mike> On 08 Apr 2021 12:32, Tom Tromey wrote: > >> >> * func.c: Include sys/time.h. > >> > Mike> this one isn't in C99. we seem to sometimes protect against it, but not > Mike> always. if we go by gnulib's notes, it seems like we should just assume > Mike> it everywhere. wdyt ? > Mike> https://www.gnu.org/software/gnulib/manual/html_node/sys_002ftime_002eh.html#sys_002ftime_002eh > >> > >> Makes sense to me. > >> > >> Also, BFD removed the check for time.h, among other things, in commit > >> 83c79df86. If BFD can remove it, I think it's fine. > > Mike> we removed time.h checks in 68ed2854284d415a71efd856a40343f550881ede in sim > Mike> since it's in C99. this question is about sys/time.h which is different. > > Sorry, I meant to say sys/time.h there. > The BFD ChangeLog says: > > * configure.ac: Don't check for long long or long double type. > Don't check for alloca.h, limits.h, stddef.h, stdlib.h, string.h, > strings.h, time.h, wchar.h, wctype.h or sys/time.h. [...] > > So I still think it's fine. gdb & sim document their expectations (C11/C++11). i guess we nee to do the same thing under BFD ? and include the stuff it expects beyond C11. -mike