From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HKAxA2oxb2DuFAAAWB0awg (envelope-from ) for ; Thu, 08 Apr 2021 12:38:02 -0400 Received: by simark.ca (Postfix, from userid 112) id F02621EE0E; Thu, 8 Apr 2021 12:38:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 589AB1E54D for ; Thu, 8 Apr 2021 12:38:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D2F523947411; Thu, 8 Apr 2021 16:38:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2F523947411 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617899880; bh=nLIPHxWI0aKzTjJAAbDTwSBwew7D61E6H0Pu8hjXS/E=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MfshUUijv76PJNfx5YLIb825hersEHpMn0R04XDGym3CKwD/iZpkoFQ6Flm9BqU15 lHA2XUuoZKXzJ4tKWvoRwTW8eciY04zxBNGwAxEceDWIGpufdjETUAMYwqYVgdALLx PX5Mt6V7bY4xfNXslAtYxmS2rRNlQ9uqtFPOXNDE= Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id A619F3947411 for ; Thu, 8 Apr 2021 16:37:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A619F3947411 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id A28FC34058A; Thu, 8 Apr 2021 16:37:56 +0000 (UTC) Date: Thu, 8 Apr 2021 12:37:55 -0400 To: Luis Machado Subject: Re: [PATCH,v2][sim,moxie] Fix DTB generation mechanism and build failure Message-ID: Mail-Followup-To: Luis Machado , gdb-patches@sourceware.org References: <20210407193929.1251903-1-luis.machado@linaro.org> <20210408144010.1334633-1-luis.machado@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210408144010.1334633-1-luis.machado@linaro.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 08 Apr 2021 11:40, Luis Machado wrote: > -moxie-gdb.dtb: moxie-gdb.dts > - dtc -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts > +moxie-gdb.dtb: @MAINTAINER_MODE_TRUE@ moxie-gdb.dts > + if test "x$(DTC)" != x; then \ > + $(DTC) -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts ; \ needs `|| exit 1` to catch failures > + $(SHELL) $(srcroot)/move-if-change moxie-gdb.dtb ${srcdir}/moxie-gdb.dtb ; \ same here > + fi ; can you add a warning as an else case that the file has not been updated due to missing dtc program ? and delete this trailing ; otherwise, lgtm! -mike