From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yP66BYAVbmAjdgAAWB0awg (envelope-from ) for ; Wed, 07 Apr 2021 16:26:40 -0400 Received: by simark.ca (Postfix, from userid 112) id 158ED1E965; Wed, 7 Apr 2021 16:26:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7A6561E01F for ; Wed, 7 Apr 2021 16:26:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E8DFF3857814; Wed, 7 Apr 2021 20:26:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8DFF3857814 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617827198; bh=2bdOXyvG61O+oQLU2TyEPBxZgOqrqruqckqndgW9/j8=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vGAO1ldvBeHIOOYWxKiKqcUCGwZtLEfVYu+5XzlpRa2rGHRlSkTLB1e28uWpXjQCl GBbJ7MVp79F1tKzeEg4Ob2LYmlZzMCpxdJsi2WgRSABCmDRWTkMKxXtClO72EELV91 xLscCag1QK6/K411TW88IJTOZ4SsEUyZWQ2kcjlk= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id E43C63857814 for ; Wed, 7 Apr 2021 20:26:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E43C63857814 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E24D0335CB7; Wed, 7 Apr 2021 20:26:29 +0000 (UTC) Date: Wed, 7 Apr 2021 16:26:28 -0400 To: Luis Machado Subject: Re: [PATCH] [sim,moxie] Fix DTB generation mechanism and build failure Message-ID: Mail-Followup-To: Luis Machado , gdb-patches@sourceware.org References: <20210407193929.1251903-1-luis.machado@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210407193929.1251903-1-luis.machado@linaro.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 07 Apr 2021 16:39, Luis Machado via Gdb-patches wrote: > I ran into a build failure with --enable-targets=all due to the fact that > the moxie sim expects to be able to use the dtc tool. If it isn't available, > the builds fails. > > Given the device tree compiler (dtc) is not available everywhere, it seems > fair to only generate the DTB file on the spot if we have such a tool. For > those who don't have the tool available, we can use a prebuilt version of the > DTB available in the repository. i think i asked about vendoring the tool in, but i think people were (understandably) not super keen on the idea since it's not GPL or GNU. > The DTS file hasn't changed since ~2009, so it seems pretty safe to assume > a prebuilt version is suitable to be used. and because it's quite small. if it were much larger, i don't think we'd want to do it this way. > I also checked that the DTB file generated on an x86_64-Linux machine is the > the same as the one generated on an AArch64-Linux machine. right, by design, it should be stable no matter where it's created. > Tested by running make/make install with/without the dtc tool. i think we want to fold this under the existing maintainer logic. check out commit 8c379db285f2ab8ad298288e86103548b90674a2 for a bit more detail. we'd want to only update+install the version in the source tree rather than switch between the one in the srcdir & the builddir one. also look at how move-if-change is used in common/Make-common.in. lmk if that's too vague :). -mike