From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id j+oxLC4PXWDZMgAAWB0awg (envelope-from ) for ; Thu, 25 Mar 2021 18:31:10 -0400 Received: by simark.ca (Postfix, from userid 112) id A7A341EF7C; Thu, 25 Mar 2021 18:31:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 167E31EF5D for ; Thu, 25 Mar 2021 18:31:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56BDA3858039; Thu, 25 Mar 2021 22:31:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56BDA3858039 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616711469; bh=HmuhDgziF2J3lO19j3NFO89jFeo5J+7G6uo65PSBPp4=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XcDhWPwkfRtYkaoZyUT7HLdFV3JpS2W5Sbntfv2n9jC9FEL9OdmRJ8h5NEECfzhAA wUUsjJA4w1b6pvVjTIQTW2OPxlcofXM3RO8cE87i4+eA39psgIcK8al0xYX/yH5kSh LtuxB4Cr0k7TRwFg7aW7YOMH9VnCH8NKPrrL0cu0= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id BD0223858039; Thu, 25 Mar 2021 22:31:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BD0223858039 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id EE877335CEC; Thu, 25 Mar 2021 22:31:04 +0000 (UTC) Date: Thu, 25 Mar 2021 18:31:04 -0400 To: Luis Machado Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. Message-ID: Mail-Followup-To: Luis Machado , Alan Modra , Tom Tromey , Alan Modra via Binutils , gdb-patches@sourceware.org References: <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> <20210322120652.GV6791@bubble.grove.modra.org> <20210322225639.GY6791@bubble.grove.modra.org> <0520bcb8-1945-5f0f-87d1-14785b881c45@linaro.org> <20210325115413.GB5425@bubble.grove.modra.org> <1e7e6f28-c916-f138-63c5-ca27f191f994@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1e7e6f28-c916-f138-63c5-ca27f191f994@linaro.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Tom Tromey , Alan Modra via Binutils , gdb-patches@sourceware.org, Alan Modra Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 25 Mar 2021 16:47, Luis Machado wrote: > On 3/25/21 8:54 AM, Alan Modra wrote: > > On Thu, Mar 25, 2021 at 07:53:04AM -0300, Luis Machado wrote: > >> On 3/22/21 7:56 PM, Alan Modra wrote: > >>> On Mon, Mar 22, 2021 at 01:13:00PM -0300, Luis Machado wrote: > >>>> Just FTR, I'm seeing breakage in sim/aarch64 and sim/arm. Both are > >>>> complaining about "-Werror=implicit-function-declaration" regarding strncmp > >>>> and strlen. > >>>> > >>>> Is this the breakage you're talking about? Just so I know what to expect > >>>> when it gets fixed. > >>> > >>> Yes. > >>> > >> > >> Thanks. Are there plans to address this or should I come up with a patch? > > > > I posted a patch here > > https://sourceware.org/pipermail/binutils/2021-March/115863.html > > It's been tested with gdb, sim and binutils builds. > > > > Tom offered to solve the problem himself, so I'm waiting on that or > > for someone in the gdb camp to review my patch. Since I messed this > > up in the first place by taking a comment by Tom as a go-ahead rather > > than first posting a patch for proper review by gdb maintainers, I'm > > being a little cautious in committing the above patch. > > > > I applied the above patch to today's master binutils-gdb and gave > configure's --enable-targets=all a try, but I ran into the following: > > In file included from ../../../repos/binutils-gdb/bfd/archive.c:135: > ./bfd.h:568:1: error: redefinition of ‘startswith’ > 568 | startswith (const char *str, const char *prefix) > | ^~~~~~~~~~ > In file included from ../../../repos/binutils-gdb/bfd/sysdep.h:122, > from ../../../repos/binutils-gdb/bfd/archive.c:134: > ../../../repos/binutils-gdb/bfd/../include/str-util.h:23:1: note: > previous definition of ‘startswith’ was here > 23 | startswith (const char *str, const char *prefix) > | ^~~~~~~~~~ Alan's patch didn't include the regenerated bfd.h inputs, so you'll have to do that on your side. -mike