Re: [PATCH] arc: Fix gcc-4.8 compilation failure for arc.c

Tom Tromey
2021-02-09T14:52:48Z

Shahab> target_desc *tdesc = arc_create_target_description (features);

Shahab> - /* Add the newly created target description to the repertoire. */
Shahab> - arc_tdesc_cache.emplace (features, tdesc);
Shahab> + /* Add the newly created target description to the repertoire.
Shahab> + PR build/27385: Use "target_desc_up ()" ctor explicitly. */
Shahab> + arc_tdesc_cache.emplace (features, target_desc_up (tdesc));

Shahab> return tdesc;

I was going to suggest that arc_create_target_description return a
target_desc_up, but when I look at the code, I see it already does, and
that this line is different:

arc_tdesc_cache.emplace (features, std::move (tdesc));

So I suspect this is already fixed.

Tom