Re: [PATCH] sim: testsuite: push $arch out to targets

Mike Frysinger via Gdb-patches
2021-01-18T18:01:56Z

On 18 Jan 2021 09:52, Andrew Burgess wrote:
> * Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-17 11:09:45 -0500]:
> > This is needed to move to automake & its dejagnu-provided logic,
> > and eventually by the unified sim logic.
>
> I looked through this patch and I didn't understand what's going on
> here.
>
> Why do you need to set the global arch in some, but not all tests?

it is being done in all tests. which ones do you think i skipped ?

> If this needs doing at all, could it not be done in some global location?

the sim ports use a unique subdir for their `run` program. the tests
need to find that path. this $arch value is what binds the specific
subdir to the test.

as we do multibuilds, we'll have multiple ports active, so a single
variable won't cut it. moving it here and out of autotols enables
that. as we do multitarget, this will help smooth the transition as
we won't have to juggle each arch as it migrates.
-mike