Re: [PATCH] sim: testsuite: push $arch out to targets

Andrew Burgess
2021-01-21T09:22:59Z

* Mike Frysinger <vapier@gentoo.org> [2021-01-18 13:01:53 -0500]:

> On 18 Jan 2021 09:52, Andrew Burgess wrote:
> > * Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-17 11:09:45 -0500]:
> > > This is needed to move to automake & its dejagnu-provided logic,
> > > and eventually by the unified sim logic.
> >
> > I looked through this patch and I didn't understand what's going on
> > here.
> >
> > Why do you need to set the global arch in some, but not all tests?
>
> it is being done in all tests. which ones do you think i skipped ?

That's my bad, I hadn't realised just how few *.exp files there are in
the sim testsuite tree.

>
> > If this needs doing at all, could it not be done in some global location?
>
> the sim ports use a unique subdir for their `run` program. the tests
> need to find that path. this $arch value is what binds the specific
> subdir to the test.

I don't understand that paragraph I'm afraid.

I guess my question is each *.exp file gets invoked by dejagnu, but
there are other hooks that dejagnu calls, like the ${tool}_init proc.
Could we not use that to set these things instead? It seems like
there's a 1:1 mapping between [istarget ????] patterns and the values
pushed into both arch and all_machs.

>
> as we do multibuilds, we'll have multiple ports active, so a single
> variable won't cut it. moving it here and out of autotols enables
> that. as we do multitarget, this will help smooth the transition as
> we won't have to juggle each arch as it migrates.

Again, I don't understand this, or how it relates to this discussion.
Sorry.

Thanks,
Andrew