From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 31YIH3aIyGNgzxkAWB0awg (envelope-from ) for ; Wed, 18 Jan 2023 19:01:58 -0500 Received: by simark.ca (Postfix, from userid 112) id 7325B1E128; Wed, 18 Jan 2023 19:01:58 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=KcIM+9Lg; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 152501E110 for ; Wed, 18 Jan 2023 19:01:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50A173858C00 for ; Thu, 19 Jan 2023 00:01:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50A173858C00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674086516; bh=uR4KruTf7D9f2t5C4zKuLJJA9g2pQ86PO8nTcEz3DhE=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=KcIM+9Lg4PzhqLpLz9c1At+gGm2ThY8C82odweqyBiOuMYWo4lY0c6Sw8cckYclCz L8D6nld5y3FRY1Zj0oe8akJKgajlgnCbdsTygJtsWabviMGpbONO7lEWt3Y1KCfVlk efgZpQoX/Q4YLltS4TMtA6KKq/Az9eChCJYyoIDs= Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 5B3AA3858C52 for ; Thu, 19 Jan 2023 00:01:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B3AA3858C52 Received: by smtp.gentoo.org (Postfix, from userid 559) id 7AC9F340BE2; Thu, 19 Jan 2023 00:01:25 +0000 (UTC) Date: Wed, 18 Jan 2023 19:01:24 -0500 To: Mark Wielaard Cc: gdb-patches@sourceware.org, Sam James Subject: Re: [PATCH] sim: mn10300: minimize mn10300-sim.h include in sim-main.h Message-ID: References: <20230115202009.149626-1-mark@klomp.org> <20230118215314.GB6144@gnu.wildebeest.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D4jtGrHdAaGBYDyY" Content-Disposition: inline In-Reply-To: <20230118215314.GB6144@gnu.wildebeest.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --D4jtGrHdAaGBYDyY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 18 Jan 2023 22:53, Mark Wielaard wrote: > On Sun, Jan 15, 2023 at 04:47:44PM -0500, Mike Frysinger wrote: > > On 15 Jan 2023 21:20, Mark Wielaard wrote: > > > --- a/sim/mn10300/sim-main.h > > > +++ b/sim/mn10300/sim-main.h > > > @@ -38,7 +38,14 @@ mn10300_core_signal ((SD), (CPU), (CIA), (MAP), (N= R_BYTES), (ADDR), (TRANSFER), > > > #include "sim-fpu.h" > > > #include "sim-signal.h" > > > =20 > > > +/* These datastructures and defines are only used by the igen genera= ted > > > + support.c, semantics.c, idecode.c and engine.c files. */ > > > +#if defined(SUPPORT_C) \ > > > + || defined(SEMANTICS_C) \ > > > + || defined(IDECODE_C) \ > > > + || defined(ENGINE_C) > > > #include "mn10300-sim.h" > > > +#endif > >=20 > > a nifty hack. can you move the sim-fpu.h & sim-signal.h inside this > > block ? >=20 > Sure. That does mean sim/mn10300/{dv-mn103cpu.c,interp.c,op_utils.c} > need to also explicitly include one or both of these files. But I > guess that these explicit includes are the intention. yes, that's the direction we want to go > See attached. OK to push like that? lgtm, thanks -mike --D4jtGrHdAaGBYDyY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmPIiE8ACgkQQWM7n+g3 9YGOmRAA3z7KXOULBl+8azNo7Hf4nVnWTXU4iqgO+nEwBXargfdfbBAZVOyafk44 27s+MSU8YL8G/uAunyBzmfudqkAy7mmsYGyFKp11OMnQkb+J5aR7frV6fLdLTv1t Wjg0pbV+rvQkMDHzpXhbss67vuUNJM/FZeVnywHfP5xOIafiYSLhAES2GyNGFyNV hLBuFyJKXmTrsgAotVVrkaUDiiFTw90gikwd4wwRXejeZo5NzrKUKepyAibnpjjR DyRifD8rl9Vy7/BDm9QwCILnyJRt5KLxTFVqntY4T6FZPubuMqas/es0wsh4cJBt OUzV7QOPD+wzV/OB79YkzLSce428YfNyKdw+O6eoMNCYQrQ+YSS7IdFbVanvyt+6 6D9idVQzuFaXIam6IqvpXVp/VeDoXJxs5c0WVOFwBFHWGIQoOej5M+vcG3ir/Kgb 84ejefUrDqjjy2Lyt3y2s/bc39NU/h2HVXkSg7OC1QLCN9NNS/Rg6rlUZg6q2P5G M2tuhuP8wJ5r0WGgtE0oIhh4p+X/A1wWBG8k6YaoAaRzTet7dtPQ39Kz4MuMLBy6 7kzLeObFyXO28zejgiwNkMipA7/wUVANTFeEVAf1ehyGwJSSPkzhsEuRMjck7oPn AaPeUPh2fGzjSrAVSUucQeRHxx5Jq5DzxGNG00PB44lZ8bUTbMk= =J5+w -----END PGP SIGNATURE----- --D4jtGrHdAaGBYDyY--