From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9XlUM65oVWPUxQ8AWB0awg (envelope-from ) for ; Sun, 23 Oct 2022 12:15:42 -0400 Received: by simark.ca (Postfix, from userid 112) id C05051E112; Sun, 23 Oct 2022 12:15:42 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=r7RyyIGB; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5AA641E0D5 for ; Sun, 23 Oct 2022 12:15:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A7F93858CDB for ; Sun, 23 Oct 2022 16:15:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A7F93858CDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666541741; bh=60Fz1VK9bOMxmtNLSVD2lsPmJNWcCOmeLMV1Qthmc8Q=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r7RyyIGBNMnF4Hb4hBVx5P7LzQ31E+zHz+Crwp2qrps4qWg9MJPQF7HjMJ4XS4wHN oDy8pf2O+5RNZrsF9trRfY3YbPzv3FlqKDGyIeDWpaERNRtzvl9czE4HSvKFeqnElR r7bO7eIxzWNw82XR74H1tQa43tCKPNj7AjMYLeoI= Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 52BAE3858D39 for ; Sun, 23 Oct 2022 16:15:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52BAE3858D39 Received: by smtp.gentoo.org (Postfix, from userid 559) id 07266340D5A; Sun, 23 Oct 2022 16:15:21 +0000 (UTC) Date: Sun, 23 Oct 2022 20:45:55 +0545 To: Tsukasa OI Subject: Re: [PATCH 24/40] sim/mips: Fix enum type-related issues on cp1.c Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZR5iAiFuKXAfe8LP" Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Nick Clifton , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --ZR5iAiFuKXAfe8LP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 20 Oct 2022 09:32, Tsukasa OI wrote: > --- a/sim/mips/cp1.c > +++ b/sim/mips/cp1.c > @@ -1178,7 +1178,7 @@ inner_rsqrt(uint64_t op1, > uint32_t res; > sim_fpu_32to (&wop1, op1); > status |= sim_fpu_sqrt (&ans, &wop1); > - status |= sim_fpu_round_32 (&ans, status, round); > + status |= sim_fpu_round_32 (&ans, (sim_fpu_round) status, (sim_fpu_denorm) round); this doesn't look correct at all. are you sure about this ? > @@ -1216,7 +1216,7 @@ fp_inv_sqrt(sim_cpu *cpu, > FP_formats fmt) > { > sim_fpu_round round = rounding_mode (GETRM()); > - sim_fpu_round denorm = denorm_mode (cpu); > + sim_fpu_denorm denorm = denorm_mode (cpu); this looks fine > @@ -1903,8 +1903,8 @@ convert_ps (sim_cpu *cpu, > case fmt_ps: > - status_u |= sim_fpu_round_32 (&wop_u, 0, round); > - status_l |= sim_fpu_round_32 (&wop_l, 0, round); > + status_u |= sim_fpu_round_32 (&wop_u, 0, (sim_fpu_denorm) round); > + status_l |= sim_fpu_round_32 (&wop_l, 0, (sim_fpu_denorm) round); this also looks wrong -mike --ZR5iAiFuKXAfe8LP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVVycACgkQQWM7n+g3 9YE93xAA3c9adrN9/i2rHxWeugq17NGjRhlRo0jql/wfCrm/yfJ74TMvizZIY92q nXlsUsDqWzX7ouh/LbRRq62xrhBV4u5BTpUmyJKM5TuMNg7YcOL26iI4dI6LbGfo j1LAKqr8wdqmuMzTLKR/sIWmLqojgjZAjuQ4+f0QkDB9iVBpD3texg5va4He5AHP 8DHFFsK1i3OiY1+kWO/6SsObN54vgGt675JuXCG1qKx1cbQENf50tK2tAzSa7Vdk QdKg9B5slBmH0wGVZU4O0rNR2ArK6Y6yvgFwf+c3DQVzOBEbTSc5YJRz6b2PGEV9 bcB6hHExqtrqrG1iHcWrLOx8gOQN22+WIjPwGA6liDFtjzvqx+CnnLN83o3fscm4 78PNp9agpjakpMSVruvDaiGXVVSVgH7Kt4SoenNtyzM5MzrMMG2acP45jRdF1eVV Utskhq/9mZD/RKHCXaxmixxalzko2wpTBGUeFxtqgTNJE4aVvIHyhv9yaUx3gPGH I/STbE+3yI8P28vEQrsYXz3AMvAWsF1Tq3idNmEfHrygWOAAABwiCgbIZzXcRZVp rdgyWDfEN2JLCr8EUnfri2sGs2hYeNM8kLpiiV4BQ7s5gPjDNt2k5MCWQpPatF8v LoE/zkOl0VMGokkA9vE1ubkmgYSlQqGmHAbUhd/dM9lwavriFrw= =iALW -----END PGP SIGNATURE----- --ZR5iAiFuKXAfe8LP--