From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4Tx+K7FlVWOlxA8AWB0awg (envelope-from ) for ; Sun, 23 Oct 2022 12:02:57 -0400 Received: by simark.ca (Postfix, from userid 112) id 9FC601E112; Sun, 23 Oct 2022 12:02:57 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=JcyC8Y2L; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 41D081E0D5 for ; Sun, 23 Oct 2022 12:02:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 992263858D28 for ; Sun, 23 Oct 2022 16:02:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 992263858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666540976; bh=obq5etTAsC05EHYwekWxaYFnrvO/m6OEHz97h7Q6tSk=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=JcyC8Y2L5owsXhBwDM7LDDwB6/kxyc9wWGVUWsEtKS8Sd/8iArrFFrJznjlSUj+ag bDCF3ShD6Tx7DAJOYUnlAMAVh/a0StCIVsN4hsKB+iraBtxF6aV8cxeeSEi07UNkZg riiphxqqw5quMsPSU1n35n6biorUXgWKxEZTnVlI= Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id B7D3E3858D28 for ; Sun, 23 Oct 2022 16:02:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7D3E3858D28 Received: by smtp.gentoo.org (Postfix, from userid 559) id 658B6341186; Sun, 23 Oct 2022 16:02:36 +0000 (UTC) Date: Sun, 23 Oct 2022 20:33:10 +0545 To: Tsukasa OI Subject: Re: [PATCH 18/40] sim/m32c: Stop using middle dot Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FmvWLhzyxw12wF9u" Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Nick Clifton , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --FmvWLhzyxw12wF9u Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 20 Oct 2022 09:32, Tsukasa OI wrote: > The led_off array used 0xB7 (Latin-1 middle dot) but it heavily depends on > the source code encoding. Directly using 0xB7 here is very dangerous and "very dangerous" is questionable > Clang causes a compiler warning ("-Winvalid-source-encoding"). > On the other hand, using '\u00b7' here will assume UTF-8. we only care about UTF-8. no other encoding (except ASCII) matters. > As a workaround, this commit replaces uses of 0xB7 with '.' > (regular ASCII dot). i don't have a sense of what this code is meant to do. is it just debug output for devs staring at the console ? probably because of the CSI escape sequences here (\e[m). if that's the case, i'm fine with changing it. i'll note that the RX port seems to use @ & * instead ... -mike --FmvWLhzyxw12wF9u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVVCoACgkQQWM7n+g3 9YHwnQ//RuGLLA+7DDEAol2mnW0K33pmALLe+0pmfIRQbYGzZL25NW1Ev1Wj+1rK ibwGGKs+pWEjXvTJPKePpXHbY16nW+/6s1WMgCxtmUAU4d/XsYD7qQGvmSuCYS5a FEeYBGzGZt5GNbO9gRybLEhcby4VwXquKUjvU89zcenBWNPgYdwxnG8Manq9CiYF M6sSFcUnYWfL0AmeGBexBJHideYlUEsoOz26cGtBQsiP6skQU/RiOaO6FqZhZbgc 51k56+mBmA3xR+7AmZ/7kzOSThtOGvALwYOZa6tvEIxSzzRpSMczDlxmY+MYSUTr NB70g9FjKfb8jgP9n+CRjw21j32RzWnla3fWwucgsext5HUxT2SP93YsZOvPwP3E NW3RTSEzB/kbIt2UBFFA33KSm/S3CcI6Rs70bVTwv77WXHk2KPy0bpqDl0tcqnDl 9fsdsBN5iv6URQ3J8RpfS5XJaiEJ45AoY4zeSEKd2J5ux8I5qJZHLu6L97OP9534 /9ZuyIZwVordCwQ5+IKFWGBU+Tn3oEwsN6d1TIN+DLQk9qZRPfNY/Tj4W9XiTkgl KpWNIXK1SRiXVLSSOvLgzZ7xsn+jnDW2XjU2p6BC0IxSt3aY2qbRU6ms6TND1oyP 2JRaNXEKeY8i8w7Y4zvLmQphfgwfUVa4V1Tv4TKdjlXPUZRK9d8= =THd/ -----END PGP SIGNATURE----- --FmvWLhzyxw12wF9u--