From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JBmAEhliVWPOww8AWB0awg (envelope-from ) for ; Sun, 23 Oct 2022 11:47:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 3B5781E112; Sun, 23 Oct 2022 11:47:37 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=YqCQwzC7; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DAC221E0D3 for ; Sun, 23 Oct 2022 11:47:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4E6E3858C2C for ; Sun, 23 Oct 2022 15:47:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4E6E3858C2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666540055; bh=sdsL91zKSyblnywRMr7SgYnw+TlYRF+9Tthiwefc+og=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YqCQwzC79ZiTZFJ6b9G1KKBP0tnsz5VZON4xbiq2y82Jdq4y1X5Xl79jWQzraUNu0 THPxQ9dxSxKsdw2QxXoXH+yKqwttEIYeoPVrCVEB3q/Y00nNE5d/3qBtEQpOYTwP1p i5iSP/8ZaVw4mHr3zTmgkSi8pahQIchBmq8YYJWk= Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id D67073858D28 for ; Sun, 23 Oct 2022 15:47:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D67073858D28 Received: by smtp.gentoo.org (Postfix, from userid 559) id 717A734117F; Sun, 23 Oct 2022 15:47:15 +0000 (UTC) Date: Sun, 23 Oct 2022 20:17:49 +0545 To: Tsukasa OI Subject: Re: [PATCH 09/40] sim/erc32: Use int32_t as event callback argument Message-ID: Mail-Followup-To: Tsukasa OI , Andrew Burgess , Nick Clifton , gdb-patches@sourceware.org References: <057c2f8392410494c3bc5dc98052246508e6a73e.1666258361.git.research_trasio@irq.a4lg.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FxvJYgAfqT92kn+S" Content-Disposition: inline In-Reply-To: <057c2f8392410494c3bc5dc98052246508e6a73e.1666258361.git.research_trasio@irq.a4lg.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Nick Clifton , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --FxvJYgAfqT92kn+S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Oct 2022 09:32, Tsukasa OI wrote: > Clang generates a warning if an argument is passed to a function without > prototype (zero arguments, even without (void)). Such calls are deprecat= ed > forms of indefinite arguments passing ("-Wdeprecated-non-prototype"). > On the default configuration, it causes a build failure (unless > "--disable-werror" is specified). >=20 > To fix that, this commit makes struct evcell to use int32_t as a callback > (cfunc) argument of an event. would help to mention that int32_t was picked because that's what some parts of the event/callback code is already using. > --- > sim/erc32/erc32.c | 28 ++++++++++++++-------------- > sim/erc32/func.c | 8 ++++---- > sim/erc32/sis.h | 4 ++-- > 3 files changed, 20 insertions(+), 20 deletions(-) README.sis needs updating. otherwise looks OK. -mike --FxvJYgAfqT92kn+S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVUJEACgkQQWM7n+g3 9YEBWBAAy/pOS3Nv+N9XjHQykJsjj7qN/OGskKO93VtT1gE/m4gBYlEgwP8tR3+r ML235jBJLIw/vnyN8dPLtMhv2+qSC6jE95PmXfVEIDvnjbZL7gGVSP7G6/6kQXH7 suQ6jRK67sgzHn+yqzGZwoJZhhpTtQIVM6Vldy7kWdk7CnT+XC5Evioi2LmP1taL 3nCY09f73/1VDDMKf1SzorF9NiJVdZW0zzHv6atwXay1s+HgyZ1g8LHYbxdWgBME S8n0jw9OE8XwFIny6pAXaPTdF05guNGJQpbMLil0Hvlc4oaIgbvTUczkO9HcZZH/ KFZ9SHgcVQ4fbJban1c+ZxgtD8PiePVv/hNQkgaAZ9os7qQO6yX53wV9vOBPGzlo p+TOqAGbEWushMzGhr54HC1yCz/JKuubS0EsNcVTM2VDvce4xhtNeS2PF0vXIa90 dMBYWrlJjKfZABRLrFwBG1w1BnmJU3dD6nqC/ZXWka5TKCZ9VwhTiciiIyG9mSYG LY0QsC9b49cFMnrzMUhwZdizUmc7UwcUP/VFAWxs/1jWTQ20dh9cXwxGUdBXw8ai 1TCRTpN8yq1ODRa5gsgz2MwC0SHbpRxSX5nfrbzbg53saa+JxLL+9gtv1yAVpKjW mSYYAQ9ta1kq0TdjCF2AoSDmvj65X8mYaB2zaGaraNud7vX6J/o= =VjYu -----END PGP SIGNATURE----- --FxvJYgAfqT92kn+S--