From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /25oB4lFVWM8vQ8AWB0awg (envelope-from ) for ; Sun, 23 Oct 2022 09:45:45 -0400 Received: by simark.ca (Postfix, from userid 112) id 11E681E112; Sun, 23 Oct 2022 09:45:45 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=IWUmRQoF; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B956B1E0D3 for ; Sun, 23 Oct 2022 09:45:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 64A5E3856972 for ; Sun, 23 Oct 2022 13:45:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 64A5E3856972 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666532743; bh=Xf/1N5I/F9ve65Alm5EdnSCpLUvlpIH06gsEzGPE1Os=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=IWUmRQoF3zKsOc8NhnvKjDU4ZvtGMuoGoLmLjumgh/oAXkpytvrujfTqbppGSgZIV PL7kmWeLEZD+ndx+I2b+42UEgEeiWFm4qdiPbyZDCxP28tWwMq1x01GPhhLrtJDoub zQ9MDg1cBwkC2/dXDgt0+/BXjRqv0UAn9ebvenbY= Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 7423B3856DEA for ; Sun, 23 Oct 2022 13:45:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7423B3856DEA Received: by smtp.gentoo.org (Postfix, from userid 559) id 0ECD4340CCD; Sun, 23 Oct 2022 13:45:23 +0000 (UTC) Date: Sun, 23 Oct 2022 18:15:56 +0545 To: Andrew Burgess Subject: Re: [PATCH 1/5] sim/cgen: mask uninitialized variable warning in cgen-run.c Message-ID: Mail-Followup-To: Andrew Burgess , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B8d+yBcucN80wX8L" Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --B8d+yBcucN80wX8L Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 12 Oct 2022 13:38, Andrew Burgess via Gdb-patches wrote: > --- a/sim/common/cgen-run.c > +++ b/sim/common/cgen-run.c > @@ -242,6 +242,11 @@ engine_run_n (SIM_DESC sd, int next_cpu_nr, int nr_c= pus, int max_insns, int fast > prime_cpu (cpu, max_insns); > } > =20 > + /* Ensure the remaining engine_fns slots are initialized, this silence= s a > + compiler warning when engine_fns is used below. */ > + for (i =3D nr_cpus; i < MAX_NR_PROCESSORS; ++i) > + engine_fns[i] =3D NULL; engine_fns is declared in this func. why not assign it and let gcc handle the rest ? - ENGINE_FN *engine_fns[MAX_NR_PROCESSORS]; + ENGINE_FN *engine_fns[MAX_NR_PROCESSORS] =3D {}; -mike --B8d+yBcucN80wX8L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNVNAAACgkQQWM7n+g3 9YGNDg//UrCF9EcwZcLZH1pkcV9aAgc+/VMrweRyO98I3nPXUX4QxBJUErXrYpIY PV7Nu7w9pypqXsRIueuz5kyGP6rwT1sz0i+eQydF8ghdEOOTQxP/jRT9zUoypAV3 VNhZ5qWRh/bqjiu3csaaogey9JBfcK2xdG8fxsV3X+Qgp3oZsjjL84fERQFv06G9 SuxRETnsPwlhk+WZPrOME2ASYMAD9IX3u+p6FUXg4fUEwGi4dR5H8iwTE8m01FA5 fovZYzivAM0G3NzyIvakNrYha+RCd7Gl3JTLcQvL1SgdKjfba9vBzSSCab0ZxUEE Q0cuIrmB3DveVsqxIoLpnnaaOxUgvxp4RSQkY3RxQ0OI5f0qScuqFGNWBjyKxrUX oi2lqGaZgOW2khU+aAYNDOrzxfeuPUUDD5aJOQHlcAmTY2YDTv4IS9nHIY+3l+FT hrhtpb1q6Z1qNn9QN0lbgEPLQmwle8dc8jAf/iOkU2+l5M0Xi3CcjBa83TaeNOAA DEm60Ae54c+BnqCwcPWlQtyPy1Lm30og7pUclJiEiq/+7QoH7dcA1ooVnF5Fsv74 rSr3AQlNCSLj30oLDWE38K4IUiXm1N84bo8ArWn1lUSchcnCkkhiDfv2Z4DMYsBC SJgXuGPpNyN+Xf5e9mquCqQMbeATWFX5gK5dLKsJHWsOGzvVm6U= =H0OM -----END PGP SIGNATURE----- --B8d+yBcucN80wX8L--