Re: [PATCHv2] Make "skip" work on inline frames

Simon Marchi
2019-10-31T16:53:52Z

On 2019-10-31 12:42 p.m., Pedro Alves wrote:
> On 10/30/19 9:56 PM, Bernd Edlinger wrote:
>> +if { [prepare_for_testing "failed to prepare" "skip2" \
>> + {skip2.c skip1.c } \
>> + {debug nowarnings optimize=-O2}] } {
>
> Instead of -O2, could you make this use -O0 (the default),
> and then use attribute((always_inline)) to force inlining?
> We do that in some tests. E.g., gdb.opt/inline-locals.c.

I think that's a good suggestion, but just be aware that there used to be
some problems with always_inline, e.g.:

https://sourceware.org/bugzilla/show_bug.cgi?id=13263
https://sourceware.org/bugzilla/show_bug.cgi?id=12429

I'm not sure if those are still valid. If they are, it might be more difficult
that expected to use always_inline.

Simon