Re: [PATCHv2] Make "skip" work on inline frames

Pedro Alves
2019-10-31T16:42:32Z

On 10/30/19 9:56 PM, Bernd Edlinger wrote:
> +if { [prepare_for_testing "failed to prepare" "skip2" \
> + {skip2.c skip1.c } \
> + {debug nowarnings optimize=-O2}] } {

Instead of -O2, could you make this use -O0 (the default),
and then use attribute((always_inline)) to force inlining?
We do that in some tests. E.g., gdb.opt/inline-locals.c.

Quickly skimming the patch, I noticed a number of duplicated
test names. See:
https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique

Thanks,
Pedro Alves