From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130407 invoked by alias); 1 Dec 2019 20:46:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130395 invoked by uid 89); 1 Dec 2019 20:46:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 spammy=trouble, HTo:U*palves, aware, artificial X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-oln040092065106.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.92.65.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 01 Dec 2019 20:46:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kqErH/prwHOCJTYGtCCiY5HMB6HngmTz30y4c2MEnc0p5MAAznF4Fk1ICB6nVLMBX+kCYD88qoVYxZdBYWErRpOWNVa4Bnb7Uw67uJD4kD6MvxJPAFve7JhAJMz+QopF3ID8y2stYP1hUxPi9fsb369SLqMd2lYe/DuLTGgkTFeDrPSzHAONIk3m72szu65JuUqOn73ibgPpuSlEDxGbVoSwyv6QNckCHvwfo/txTZVTTGOSTeDGbKp0cmBxB/UZzESe3BbjewpEiDeN53BGIBErVXO5IjYWDKfYkrrzmLK5chpge8IRWEA4ly4eFKe/M3JEwe17xS5nSayxp7AQzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=36Ao7+Fl4vfQBx2efzSXlX5LTQSK7a7s6bJTN5GWsEY=; b=l//hwbQBKHPNbGMGfBRpxW7AN7cjeeFWRIeaPezL5x/I8YD4tqJW5Zi3xkNvQR8jJRt5MrV8G3gqAZU7ADe66Hu2wpe0wrOXTRY0nXxZ2WOk9MFdoekN3PtQ1SfKJ/AEYkkMeBEunam8DkIQx9cbvtnWl10pRjXaEMVaJ96beU7KdmKB6ggjy+Vk7rUc+dP0PWr6rQS47D9WrlDkl2cFsXv3E64JSh9C66HwL39vAUX0FgfRc5ZQTlAdDRDaPguv6zPdZJerIICc7J8X0vBifj2qmwFaVTMAfJfmaMN0iGrXB0T5PBtDENQiMAePIxHmAT5XZYMFI4zu1uwNwHpuLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB5EUR01FT050.eop-EUR01.prod.protection.outlook.com (10.152.4.57) by DB5EUR01HT139.eop-EUR01.prod.protection.outlook.com (10.152.5.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.18; Sun, 1 Dec 2019 20:46:12 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (10.152.4.59) by DB5EUR01FT050.mail.protection.outlook.com (10.152.5.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.18 via Frontend Transport; Sun, 1 Dec 2019 20:46:12 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::5861:779d:3997:2e70]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::5861:779d:3997:2e70%7]) with mapi id 15.20.2495.014; Sun, 1 Dec 2019 20:46:12 +0000 From: Bernd Edlinger To: Pedro Alves , Simon Marchi , "gdb-patches@sourceware.org" Subject: [PING] [PATCHv4] Make "skip" work on inline frames Date: Sun, 01 Dec 2019 20:46:00 -0000 Message-ID: References: <8fc93db4-8906-4f4e-53f4-225ebfa0115d@simark.ca> <215bbf9c-4c3c-5cd2-c657-51aa7262f234@simark.ca> In-Reply-To: x-microsoft-original-message-id: <37473548-a22f-7510-666d-994b87a716d0@hotmail.de> x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: <61D575C4DB33104595B5581E12464B1D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-12/txt/msg00026.txt.bz2 Ping... On 11/24/19 12:22 PM, Bernd Edlinger wrote: > This is just a minor update on the patch > since the function SYMBOL_PRINT_NAME was removed with > commit 987012b89bce7f6385ed88585547f852a8005a3f > I replaced it with sym->print_name (), otherwise the > patch is unchanged. >=20 > On 10/31/19 8:19 PM, Bernd Edlinger wrote: >> On 10/31/19 7:00 PM, Pedro Alves wrote: >>> On 10/31/19 4:53 PM, Simon Marchi wrote: >>>> On 2019-10-31 12:42 p.m., Pedro Alves wrote: >>>>> On 10/30/19 9:56 PM, Bernd Edlinger wrote: >>>>>> +if { [prepare_for_testing "failed to prepare" "skip2" \ >>>>>> + {skip2.c skip1.c } \ >>>>>> + {debug nowarnings optimize=3D-O2}] } { >>>>> >>>>> Instead of -O2, could you make this use -O0 (the default), >>>>> and then use attribute((always_inline)) to force inlining?=20 >>>>> We do that in some tests. E.g., gdb.opt/inline-locals.c. >>>> >>>> I think that's a good suggestion, but just be aware that there used to= be >>>> some problems with always_inline, e.g.: >>> >>> I don't think always_inline changes anything in the debug info special, >>> it just tells the compiler to inline the function even at -O0, which is >>> what we're after. >>> >>>> >>>> https://sourceware.org/bugzilla/show_bug.cgi?id=3D13263 >>> >>> This one seems to be about attribute((artificial)), and the desire >>> to not step into such functions automatically: >>> >>> "Given that I marked the function always_inline and artificial, I >>> was expecting not to step into its body." >>> >>>> https://sourceware.org/bugzilla/show_bug.cgi?id=3D12429 >>>> >>> >>> This one seems like a generic inlining issue. >>> >>>> I'm not sure if those are still valid. If they are, it might be more = difficult >>>> that expected to use always_inline. >>> I don't think always_inline is anything special compared to inlining >>> because of -O2. >>> >>> Thanks, >>> Pedro Alves >>> >> >> Ah, thanks for that hint! >> >> always_inline works quite well. >> >> The debug session started (using gcc 4.8.4) with -O2 -g on the line with= "{" in main, >> and with -O0 -g at the first real statement, so I had to remove one step. >> I did not worry about it initially, but now I agree that would have caus= ed trouble. >> >> >> I attached both parts of the patch, the fist part unchanged from previou= s. >> The test case now makes sure to not repeat the names. >> >> >> Thanks >> Bernd. >>