From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117122 invoked by alias); 2 Nov 2018 11:32:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112602 invoked by uid 89); 2 Nov 2018 11:30:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0071.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Nov 2018 11:30:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xONebntk+aXPs+hL9xnjE3lMb59PCHYFiuYQKFPVFys=; b=PK1qzSLUSlM2hwFH+elhNIjS1oSu3rsXFzT3jWZJL4Hcty5P2wESVsA3n1Alawi5kr+uBUrts9mLpM0C6ggUxXFFYcGbYhlcasglaj14RyNoEDOQWMkCO/spKipCmPJkkyYCRtVATkUZcsEs5wN0a6v/P0Dg20hBDm9VdoRZYOI= Received: from VI1PR0801MB2014.eurprd08.prod.outlook.com (10.173.74.135) by VI1PR0801MB1503.eurprd08.prod.outlook.com (10.167.210.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.25; Fri, 2 Nov 2018 11:30:10 +0000 Received: from VI1PR0801MB2014.eurprd08.prod.outlook.com ([fe80::d4a6:6311:ce23:3e17]) by VI1PR0801MB2014.eurprd08.prod.outlook.com ([fe80::d4a6:6311:ce23:3e17%2]) with mapi id 15.20.1294.024; Fri, 2 Nov 2018 11:30:10 +0000 From: Matthew Malcomson To: "gdb-patches@sourceware.org" , "palves@redhat.com" CC: nd Subject: [Patch][gdb] Initialise quiet flag for "info functions" Date: Fri, 02 Nov 2018 11:32:00 -0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Matthew.Malcomson@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: multipart/mixed; boundary="_002_VI1PR0801MB2014605E2BB011A75B4E9829E0CF0VI1PR0801MB2014_" MIME-Version: 1.0 X-SW-Source: 2018-11/txt/msg00020.txt.bz2 --_002_VI1PR0801MB2014605E2BB011A75B4E9829E0CF0VI1PR0801MB2014_ Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable Content-length: 957 With this flag unset, using 'info functions' without a set quiet flag was not deterministic and was causing some flaky test failures. Failures seen in (at least). gdb.base/info_qt.exp gdb.dwarf2/dw2-case-insensitive.exp gdb.base/info-fun.exp Ok for trunk? I don't have commit rights. gdb/ChangeLog: 2018-11-02 Matthew Malcomson * symtab.c (info_functions_command): Initialise quiet flag. ############### Attachment also inlined for ease of reply ##########= ##### diff --git a/gdb/symtab.c b/gdb/symtab.c index cd27a75e8ca2370a9d11ae6057d051ca6ce13f90..7649908d9c9341ad695626e0a22= a085f2af302ef 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -4760,7 +4760,7 @@ info_functions_command (const char *args, int from_tt= y) { std::string regexp; std::string t_regexp; - bool quiet; + bool quiet =3D false; =20 while (args !=3D NULL && extract_info_print_args (&args, &quiet, ®exp, &t_regexp)) --_002_VI1PR0801MB2014605E2BB011A75B4E9829E0CF0VI1PR0801MB2014_ Content-Type: text/plain; name="initialise-quiet.patch" Content-Description: initialise-quiet.patch Content-Disposition: attachment; filename="initialise-quiet.patch"; size=435; creation-date="Fri, 02 Nov 2018 11:30:10 GMT"; modification-date="Fri, 02 Nov 2018 11:30:10 GMT" Content-ID: <83608530847D834FA5CDFBF33A1D5ABF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 Content-length: 590 ZGlmZiAtLWdpdCBhL2dkYi9zeW10YWIuYyBiL2dkYi9zeW10YWIuYwppbmRl eCBjZDI3YTc1ZThjYTIzNzBhOWQxMWFlNjA1N2QwNTFjYTZjZTEzZjkwLi43 NjQ5OTA4ZDljOTM0MWFkNjk1NjI2ZTBhMjJhMDg1ZjJhZjMwMmVmIDEwMDY0 NAotLS0gYS9nZGIvc3ltdGFiLmMKKysrIGIvZ2RiL3N5bXRhYi5jCkBAIC00 NzYwLDcgKzQ3NjAsNyBAQCBpbmZvX2Z1bmN0aW9uc19jb21tYW5kIChjb25z dCBjaGFyICphcmdzLCBpbnQgZnJvbV90dHkpCiB7CiAgIHN0ZDo6c3RyaW5n IHJlZ2V4cDsKICAgc3RkOjpzdHJpbmcgdF9yZWdleHA7Ci0gIGJvb2wgcXVp ZXQ7CisgIGJvb2wgcXVpZXQgPSBmYWxzZTsKIAogICB3aGlsZSAoYXJncyAh PSBOVUxMCiAJICYmIGV4dHJhY3RfaW5mb19wcmludF9hcmdzICgmYXJncywg JnF1aWV0LCAmcmVnZXhwLCAmdF9yZWdleHApKQoK --_002_VI1PR0801MB2014605E2BB011A75B4E9829E0CF0VI1PR0801MB2014_--