From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66641 invoked by alias); 10 Oct 2017 18:16:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66631 invoked by uid 89); 10 Oct 2017 18:16:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.1 required=5.0 tests=BAYES_00,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 spammy=H*c:alternative, H*c:sk:VIHPRHH, forth, H*M:eurprd05 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0113.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Oct 2017 18:16:13 +0000 Received: from VI1PR0501MB2861.eurprd05.prod.outlook.com (10.172.11.151) by VI1PR0501MB2862.eurprd05.prod.outlook.com (10.172.12.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 10 Oct 2017 18:16:09 +0000 Received: from VI1PR0501MB2861.eurprd05.prod.outlook.com ([fe80::1105:ec3d:d331:ab8e]) by VI1PR0501MB2861.eurprd05.prod.outlook.com ([fe80::1105:ec3d:d331:ab8e%16]) with mapi id 15.20.0077.020; Tue, 10 Oct 2017 18:16:09 +0000 From: Peeter Joot To: Simon Marchi , "gdb-patches@sourceware.org" Subject: Re: review request: implementing DW_AT_endianity Date: Tue, 10 Oct 2017 18:16:00 -0000 Message-ID: References: <0f87cf42-781d-4d70-a389-f4688cde109d@simark.ca> ,<534b7f80-c778-d5ca-3cee-1ccbab7bf257@simark.ca> In-Reply-To: <534b7f80-c778-d5ca-3cee-1ccbab7bf257@simark.ca> authentication-results: spf=none (sender IP is ) smtp.mailfrom=peeter.joot@lzlabs.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0501MB2862;6:SwsJQuResHLRAH2Nojw7p7W3Res2Pski3G8YatgZKb17qOg9P2toGuw+0q/dfdg32yXPujO3Ssczb2V1Ye7dOeAOaWjdwV66Vv/i4mobxhkr5nvhajaZlAr8EzaHA841+khkTPjXGKv71zfdZOq7b4JlyC8us6fG3e+hZep++2KsMkPPPWwcb2Ngxq7uAeXW8Jr4A2jiTwSbgU/U14MlYjhj0G7m6fJoeVV2XxO8/JarMNAVE1nmxqKbLpwQ3Xh6YDDLZFoHQy7uvXexge306Yr/1a5K829MKjgaWY71W3pfbkV8BnitvQs9/N8goAwZnLEIiI0FsPpaaHwcLS/CVg==;5:DoLqAIoIguun8qVgWv4peFSvZG9ejPAQJvCEdsfVRytGtV/o2Ff1NbE6FTT+LC3CD0j243+lNNhmaHIbr3AU2B5TgfuKZU27XQXKESzGcxsswSk6mTibkjyB5tC96yWj+Z1gXh1zdt6PL/rYv6ZKTw==;24:VlNxL8MgEO5x3rXdx2b52qnFdkypL4iEvEbaAfe12mFBoV6RWCOFlgbBP9hLqsT11fFpJi+R/o4un9s2Nq1id4P2FNx9ypEm4hLe3ZdL7rI=;7:Iphs1mWtTY9cDOkxmuW7nzImGnVkzVH62ZZGz8IA+PQfhdKzUnCCRYQhNIzyXzvEY9XwbAAc9ar68N5NZWc7A2k2qEf2HQBVP64xAG3qYuGvg/JCyZVmUGDh6ZIXrwisPN9VaNsd+GBYhFjc0Q5OX2z9Y/hgQEzTQUMSaHmvHkI0y7ffCLVzJ5z6E0ED7Yw21UnYMdlAPrM9Q2SdPOYX55qybp+hwd5ZCFv4yTT/RNU= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 61872ef3-f348-453d-971c-08d5100afb8d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:VI1PR0501MB2862; x-ms-traffictypediagnostic: VI1PR0501MB2862: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0501MB2862;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0501MB2862; x-forefront-prvs: 04569283F9 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(189002)(199003)(105586002)(53936002)(68736007)(101416001)(74316002)(2906002)(50986999)(76176999)(54356999)(2950100002)(9686003)(54896002)(86362001)(6506006)(55016002)(99286003)(8676002)(189998001)(5250100002)(6246003)(8936002)(81166006)(81156014)(97736004)(6436002)(33656002)(6606003)(7736002)(3660700001)(93886005)(2900100001)(3280700002)(5660300001)(2501003)(478600001)(229853002)(316002)(106356001)(7696004)(6116002)(14454004)(102836003)(25786009)(19627405001)(110136005);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0501MB2862;H:VI1PR0501MB2861.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: lzlabs.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: lzlabs.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2017 18:16:09.7464 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be5a2f53-aa84-427c-8fbd-c2d71558a7a8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2862 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-10/txt/msg00250.txt.bz2 > I suggest naming this function type_byte_order. Functions named "gdbarch= _*" are usually > those part of the gdbarch interface (defined in gdbarch.sh/.h/.c). done. > Nice. Assginment of fields by GDB would be a good thing to check in the = test. done. > Ah indeed. Do you report the gcc bugs you find to them? I will verify first on the dev version of gcc8 that this is still an issue = before submitting a report. > testsuite. It is normal to see the number of tests vary when running the test suite (m= ake check -j8)? My before and after runs had an unexpected difference in t= he numbers of tests: =3D=3D=3D gdb Summary =3D=3D=3D -# of expected passes 40087 -# of unexpected failures 96 +# of expected passes 40082 +# of unexpected failures 98 # of unexpected successes 1 # of expected failures 67 # of unknown successes 3 My test added 4 additional expected passes (and I verified that my new test= s ran in gdb/testsuite/gdb.log), so the number of expected successes should= have grown by 4, not decreased by 5? Some of the failures differences loo= k like buggy tests (outputting pids and so forth). I clearly didn't regress anything significant, but didn't expect the baseli= ne to vary run to run. Peeter