From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108864 invoked by alias); 5 Apr 2016 13:08:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108853 invoked by uid 89); 5 Apr 2016 13:08:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2014 X-HELO: emea01-am1-obe.outbound.protection.outlook.com Received: from mail-am1on0092.outbound.protection.outlook.com (HELO emea01-am1-obe.outbound.protection.outlook.com) (157.56.112.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Tue, 05 Apr 2016 13:08:45 +0000 Received: from VI1PR0401MB1776.eurprd04.prod.outlook.com (10.165.234.150) by VI1PR0401MB1774.eurprd04.prod.outlook.com (10.165.234.148) with Microsoft SMTP Server (TLS) id 15.1.447.15; Tue, 5 Apr 2016 13:08:41 +0000 Received: from VI1PR0401MB1776.eurprd04.prod.outlook.com ([10.165.234.150]) by VI1PR0401MB1776.eurprd04.prod.outlook.com ([10.165.234.150]) with mapi id 15.01.0447.028; Tue, 5 Apr 2016 13:08:41 +0000 From: Catalin-Dan Udma To: Pedro Alves , Catalin Udma , "gdb-patches@sourceware.org" Subject: RE: [PATCH] testsuite: Update py-mi-objfile to expect console format print Date: Tue, 05 Apr 2016 13:08:00 -0000 Message-ID: References: <1459851290-13123-1-git-send-email-catalin.udma@freescale.com> <57039A9E.4010408@redhat.com> <5703A892.6090003@redhat.com> In-Reply-To: <5703A892.6090003@redhat.com> authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nxp.com; x-ms-office365-filtering-correlation-id: 24116e91-2046-48b6-f403-08d35d536910 x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1774;5:2Ehty1WQfiV4MxcIUZSUtTWdnPRalsMY8BOM/Z5nzV+H4Am8nKc50We2UXD0OmEU2yf5V3TYtA6VCxRev/V/ZnhG16J33g+eQ01s7E9KweQ69dyWnamTYjH59DOACXSTuTyBiFDmIp9Pz3PR6bwclQ==;24:4q4X+m446EGjIgh1ULv9RkPm07gl2Rne6kdRkLmVp4foaoB4L5JNbJwtcaasoN6Mat2v4fpA4egbI4O3ZfdG04MKxyul1Qjf8YOPMFSK40M= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1774; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:VI1PR0401MB1774;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1774; x-forefront-prvs: 0903DD1D85 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(377454003)(164054003)(93886004)(230783001)(102836003)(76576001)(2501003)(76176999)(54356999)(50986999)(6116002)(122556002)(5003600100002)(107886002)(2906002)(189998001)(106116001)(33656002)(3280700002)(81166005)(66066001)(3660700001)(5002640100001)(2950100001)(2900100001)(5004730100002)(19580395003)(74316001)(5008740100001)(10400500002)(5001770100001)(586003)(3846002)(86362001)(87936001)(15650500001)(92566002)(1220700001)(1096002)(11100500001)(77096005)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1774;H:VI1PR0401MB1776.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2016 13:08:41.4509 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1774 X-SW-Source: 2016-04/txt/msg00076.txt.bz2 >=20 > On 04/05/2016 12:45 PM, Catalin-Dan Udma wrote: > >> On 04/05/2016 11:14 AM, Catalin Udma wrote: > >>> --- a/gdb/testsuite/gdb.python/py-mi-objfile-gdb.py > >>> +++ b/gdb/testsuite/gdb.python/py-mi-objfile-gdb.py > >>> @@ -24,4 +24,4 @@ import gdb > >>> gdb.execute("set width 101", to_string=3DTrue) > >>> # And finally a command that will use the original MI stream, which = in a > >>> # buggy gdb will use just-freed data. > >>> -gdb.execute("list") > >>> +gdb.execute("list main") > >> > >> Do the comments in the test still make sense? > >> From the comment, sounds like the test might no longer be covering > >> what it intended? I.e. do we "use the original MI stream" ? > >> > >> Thanks, > >> Pedro Alves > > > > [Catalin Udma] Indeed, the original crash is no longer reproducible: I = manually > reverted the fixes > > for that crash (gdb/cli/cli-logging.c, gdb/mi/mi-out.c) and the crash i= s not > reproducible anymore > > when running py-mi-objfile.exp. > > It reproduces if I revert also this patch " python: Use console format = for > output of gdb.execute command" > > > > Updating the comments would be enough and let the test validate the same > scenario? >=20 > I think it's good to keep validating the same scenario. >=20 > Though maybe there's something else we could add that uses the > MI stream, that'd also expose the crash? Maybe >=20 > gdb.execute ("interpreter-exec mi \"-gdb-show width\"") >=20 > would work? >=20 > > "+# And finally a command that will use the console stream without > redirection" ? >=20 > Thanks, > Pedro Alves [Catalin Udma]=20 gdb.execute ("interpreter-exec mi \"-gdb-show width\"", to_string =3D True) would crash the gdb with or without any of the patches in discussion. (MI patch for crash redirection, and use console for python gdb.execute) I propose to log this new bug, and for now just update the comments in this= test. When the new bug would be fixed, the this test would be updated with the new scenario.