From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51029 invoked by alias); 5 Apr 2016 11:46:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51013 invoked by uid 89); 5 Apr 2016 11:46:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:mail-am, Hx-spam-relays-external:sk:mail-am X-HELO: emea01-am1-obe.outbound.protection.outlook.com Received: from mail-am1on0090.outbound.protection.outlook.com (HELO emea01-am1-obe.outbound.protection.outlook.com) (157.56.112.90) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Tue, 05 Apr 2016 11:46:00 +0000 Received: from VI1PR0401MB1776.eurprd04.prod.outlook.com (10.165.234.150) by VI1PR0401MB1773.eurprd04.prod.outlook.com (10.165.234.147) with Microsoft SMTP Server (TLS) id 15.1.447.15; Tue, 5 Apr 2016 11:45:56 +0000 Received: from VI1PR0401MB1776.eurprd04.prod.outlook.com ([10.165.234.150]) by VI1PR0401MB1776.eurprd04.prod.outlook.com ([10.165.234.150]) with mapi id 15.01.0447.028; Tue, 5 Apr 2016 11:45:56 +0000 From: Catalin-Dan Udma To: Pedro Alves , Catalin Udma , "gdb-patches@sourceware.org" Subject: RE: [PATCH] testsuite: Update py-mi-objfile to expect console format print Date: Tue, 05 Apr 2016 11:46:00 -0000 Message-ID: References: <1459851290-13123-1-git-send-email-catalin.udma@freescale.com> <57039A9E.4010408@redhat.com> In-Reply-To: <57039A9E.4010408@redhat.com> authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nxp.com; x-ms-office365-filtering-correlation-id: 097edc96-73f4-4a6f-b6c2-08d35d47d9be x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1773;5:dFfUdYWHmmSmJEi/5ieYH3q5b1gn/9LkM90VoAGBP5rZ+Hg6DStqnjyXvQyeLuMvXDFp+urh11+C8IyCDz6n5X4s53Vwbo52rSK0avjf3VHTzqH81auNFt5KA/L0MgzUpCl75jSo+WNaBGyVjsGeew==;24:XVk44vcQRBs7SrkXAg+SyNlwr+NK2qhEEAJTuN0zYgDWKC11tZiTKOX7oY2beRdOjccV39j1Ft+A0Ngb/mD/ZmoILCygufOhemZ3bfHsUwM= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1773; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:VI1PR0401MB1773;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1773; x-forefront-prvs: 0903DD1D85 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(164054003)(24454002)(377454003)(2950100001)(2900100001)(33656002)(1220700001)(1096002)(19580395003)(5003600100002)(2501003)(5008740100001)(66066001)(87936001)(3280700002)(102836003)(10400500002)(6116002)(3846002)(106116001)(3660700001)(2906002)(15650500001)(76576001)(586003)(11100500001)(74316001)(107886002)(50986999)(5004730100002)(122556002)(54356999)(76176999)(77096005)(81166005)(5001770100001)(5002640100001)(189998001)(230783001)(86362001)(92566002)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1773;H:VI1PR0401MB1776.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2016 11:45:56.4711 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1773 X-SW-Source: 2016-04/txt/msg00069.txt.bz2 > On 04/05/2016 11:14 AM, Catalin Udma wrote: > > --- a/gdb/testsuite/gdb.python/py-mi-objfile-gdb.py > > +++ b/gdb/testsuite/gdb.python/py-mi-objfile-gdb.py > > @@ -24,4 +24,4 @@ import gdb > > gdb.execute("set width 101", to_string=3DTrue) > > # And finally a command that will use the original MI stream, which in= a > > # buggy gdb will use just-freed data. > > -gdb.execute("list") > > +gdb.execute("list main") >=20 > Do the comments in the test still make sense? > From the comment, sounds like the test might no longer be covering > what it intended? I.e. do we "use the original MI stream" ? >=20 > Thanks, > Pedro Alves [Catalin Udma] Indeed, the original crash is no longer reproducible: I manu= ally reverted the fixes for that crash (gdb/cli/cli-logging.c, gdb/mi/mi-out.c) and the crash is no= t reproducible anymore=20 when running py-mi-objfile.exp. It reproduces if I revert also this patch " python: Use console format for = output of gdb.execute command" Updating the comments would be enough and let the test validate the same sc= enario?=20 "+# And finally a command that will use the console stream without redirect= ion" ?