From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112047 invoked by alias); 26 Oct 2019 08:06:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112005 invoked by uid 89); 26 Oct 2019 08:06:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=counted, Bernd, Edlinger, bernd X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-oln040092067017.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.92.67.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Oct 2019 08:06:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hkiWVdOj5DV034HzrrMuaSL8bDAdb0IXLSdHSXNu6UPd5UiAlo4/XXF6RhJm8lY0PEflYLMOF77tTM12kgJFk1XWDgtOqM6bzaapN5T1Gr52JBCXQ3gueRpPCwMw47lvsocKZsI3QQiLieZnwhW2hJpk50pfghTjA+QD9vTf6jXhuLtnQfFZIfqoAFEcJPko1038oCDm8sCbnqcuo1ucRnnG7CVwnriGZSRD8zIHszTw+OIyvipDcdf1SUJO7xRiR/xSxe/cXlkYIjonM+drkET7WvmfynANpLPFqHRTgH3yTcReAeTzcxlKMxsiEyUIlB/y91qJpdbSnmZ5bCgoDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xN+iAw1O/emw8eTQ3rCSIXivwsSwxip4J/r+hm6QDDk=; b=iUrt7XleM2MplX55cPWZYelszb2os2EZBsedUtk84FnHpuaEpTLLSuJ5SqOYXAKszqjbzglmIvVk9seLXCVxRuj1eKmr+EkocJkahVHjdoeW5JUmakVqONsyLFZjwgd2QkuK5ofvA1Cisjyt2O+xaasvIwW869mQtinKKKKE04thSX+veDxCkuvjdJLDanP/S6rFZi1Vka4gtr46xPiPXEhndp543n534Tpf8rkj+4iRCZMatIs7gtmlegTA7Po+A8IP9nY6T8S7eCl5sw/xIYFoFN6737Qpqwl0letrmmpiNp4mIQvWRhTqxPp1GGXcFYBsnbT8tusF5P5nnVl/dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from HE1EUR02FT004.eop-EUR02.prod.protection.outlook.com (10.152.10.54) by HE1EUR02HT044.eop-EUR02.prod.protection.outlook.com (10.152.11.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2387.20; Sat, 26 Oct 2019 08:06:11 +0000 Received: from VI1PR03MB4528.eurprd03.prod.outlook.com (10.152.10.57) by HE1EUR02FT004.mail.protection.outlook.com (10.152.10.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2387.20 via Frontend Transport; Sat, 26 Oct 2019 08:06:11 +0000 Received: from VI1PR03MB4528.eurprd03.prod.outlook.com ([fe80::49b8:a7e6:9f6f:862d]) by VI1PR03MB4528.eurprd03.prod.outlook.com ([fe80::49b8:a7e6:9f6f:862d%3]) with mapi id 15.20.2387.025; Sat, 26 Oct 2019 08:06:11 +0000 From: Bernd Edlinger To: "gdb-patches@sourceware.org" Subject: [PING] [PATCHv2] Make "skip" work on inline frames Date: Sat, 26 Oct 2019 08:06:00 -0000 Message-ID: References: In-Reply-To: x-microsoft-original-message-id: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: <2897E1A2B7D52441A584425F89410412@eurprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-10/txt/msg00940.txt.bz2 Hi, I wanted to ping for this patch here: http://sourceware.org/ml/gdb-patches/2019-10/msg00685.html Thanks Bernd. On 10/20/19 8:48 AM, Bernd Edlinger wrote: > On 10/19/19 6:38 AM, Bernd Edlinger wrote: >> Hmm, >> >> I noticed that the patch does not yet handle >> the step correctly, the count is decremented >> although the inline frame is skipped and should not be >> counted... >> >> Thus I will need to change at least this: >> >> --- a/gdb/infcmd.c >> +++ b/gdb/infcmd.c >> @@ -1122,7 +1122,6 @@ prepare_one_step (struct step_command_fsm *sm) >> set_running (resume_ptid, 1); >>=20=20 >> step_into_inline_frame (tp); >> - sm->count--; >>=20=20 >> sal =3D find_frame_sal (frame); >> sym =3D get_frame_function (frame); >> @@ -1132,13 +1131,17 @@ prepare_one_step (struct step_command_fsm *sm) >>=20=20 >> if (sal.line =3D=3D 0 >> || !function_name_is_marked_for_skip (fn, sal)) >> - return prepare_one_step (sm); >> + { >> + sm->count--; >> + return prepare_one_step (sm); >> + } >> } >>=20=20 >> >=20 > Attached is an updated patch that fixes this issue, > and also adds the following after step_into_inline_frame (): >=20 > frame =3D get_current_frame (); >=20 > That I consider safer, since this function calls reinit_frame_cache (). > It was probably just by chance that this did not seem to cause any > problems for me. >=20 >=20 > Thanks > Bernd. >=20